Deprecate tests used as filters (#32361)

* Warn on tests used as filters

* Update docs, add aliases for tests that fit more gramatically with test syntax

* Fix rst formatting

* Add successful filter, alias of success

* Remove renamed_deprecation, it was overkill

* Make directory alias for is_dir

* Update tests to use proper jinja test syntax

* Update additional documentation, living outside of YAML files, to reflect proper jinja test syntax

* Add conversion script, porting guide updates, and changelog updates

* Update newly added uses of tests as filters

* No underscore variable

* Convert recent tests as filter changes to win_stat

* Fix some changes related to rebasing a few integration tests

* Make tests_as_filters_warning explicitly accept the name of the test, instead of inferring the name

* Add test for tests_as_filters_warning

* Update tests as filters in newly added/modified tests

* Address recent changes to several integration tests

* Address recent changes in cs_vpc

lib/ansible/plugins/test/core.py

@@ -30,7 +30,7 @@ from ansible import errors
 def failed(result):
     ''' Test if task result yields failed '''
     if not isinstance(result, MutableMapping):
-        raise errors.AnsibleFilterError("|failed expects a dictionary")
+        raise errors.AnsibleFilterError("The failed test expects a dictionary")
     return result.get('failed', False)
 
 
@@ -42,7 +42,7 @@ def success(result):
 def changed(result):
     ''' Test if task result yields changed '''
     if not isinstance(result, MutableMapping):
-        raise errors.AnsibleFilterError("|changed expects a dictionary")
+        raise errors.AnsibleFilterError("The changed test expects a dictionary")
     if 'changed' not in result:
         changed = False
         if (
@@ -62,7 +62,7 @@ def changed(result):
 def skipped(result):
     ''' Test if task result yields skipped '''
     if not isinstance(result, MutableMapping):
-        raise errors.AnsibleFilterError("|skipped expects a dictionary")
+        raise errors.AnsibleFilterError("The skipped test expects a dictionary")
     return result.get('skipped', False)
 
 
@@ -129,6 +129,7 @@ class TestModule(object):
             'failure': failed,
             'succeeded': success,
             'success': success,
+            'successful': success,
 
             # changed testing
             'changed': changed,
@@ -145,6 +146,7 @@ class TestModule(object):
 
             # version comparison
             'version_compare': version_compare,
+            'version': version_compare,
 
             # lists
             'any': any,

lib/ansible/plugins/test/files.py

@@ -30,13 +30,19 @@ class TestModule(object):
         return {
             # file testing
             'is_dir': isdir,
+            'directory': isdir,
             'is_file': isfile,
+            'file': isfile,
             'is_link': islink,
+            'link': islink,
             'exists': exists,
             'link_exists': lexists,
 
             # path testing
             'is_abs': isabs,
+            'abs': isabs,
             'is_same_file': samefile,
+            'same_file': samefile,
             'is_mount': ismount,
+            'mount': ismount,
         }

lib/ansible/plugins/test/mathstuff.py

@@ -43,6 +43,9 @@ class TestModule:
         return {
             # set theory
             'issubset': issubset,
+            'subset': issubset,
             'issuperset': issuperset,
+            'superset': issuperset,
             'isnan': isnotanumber,
+            'nan': isnotanumber,
         }