ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-10-03 23:14:02 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

[PR #10712/cb84fa74 backport][stable-11] remove extra brackets when params are a given by a comprehension (#10725)

Browse source 
remove extra brackets when params are a given by a comprehension (#10712)

* remove extra brackets when function params are a given by a comprehension

* add changelog frag

(cherry picked from commit cb84fa740a)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
This commit is contained in:
patchback[bot] 2025-08-23 19:43:27 +02:00 • committed by GitHub
commit 4d6f4c82e2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 16 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

2
plugins/modules/android_sdk.py
View file

@ -160,7 +160,7 @@ class AndroidSdk(StateModuleHelper):
arg_pkgs = set(self.vars.package)
if len(arg_pkgs) < len(self.vars.package):
self.do_raise("Packages may not repeat")
return set([Package(p) for p in arg_pkgs])
return set(Package(p) for p in arg_pkgs)
def state_present(self):
packages = self._parse_packages()

4
plugins/modules/elasticsearch_plugin.py
View file

@ -238,8 +238,8 @@ def get_plugin_bin(module, plugin_bin=None):
# Get separate lists of dirs and binary names from the full paths to the
# plugin binaries.
plugin_dirs = list(set([os.path.dirname(x) for x in bin_paths]))
plugin_bins = list(set([os.path.basename(x) for x in bin_paths]))
plugin_dirs = list(set(os.path.dirname(x) for x in bin_paths))
plugin_bins = list(set(os.path.basename(x) for x in bin_paths))
# Check for the binary names in the default system paths as well as the path
# specified in the module arguments.

2
plugins/modules/manageiq_alert_profiles.py
View file

@ -201,7 +201,7 @@ class ManageIQAlertProfiles(object):
# alert which currently exist in the profile
if 'alert_definitions' in old_profile:
# we use get_alert_href to have a direct href to the alert
existing_alerts = set([self.get_alert_href(alert) for alert in old_profile['alert_definitions']])
existing_alerts = set(self.get_alert_href(alert) for alert in old_profile['alert_definitions'])
else:
# no alerts in this profile
existing_alerts = set()

2
plugins/modules/one_vm.py
View file

@ -1146,7 +1146,7 @@ def create_count_of_vms(module, client,
base_name = vm_name[:len(vm_name) - num_sign_cnt]
vm_name = base_name
# Make list which contains used indexes in format ['000', '001',...]
vm_filled_indexes_list = list((vm.NAME[len(base_name):].zfill(num_sign_cnt)) for vm in vm_list)
vm_filled_indexes_list = [vm.NAME[len(base_name):].zfill(num_sign_cnt) for vm in vm_list]
while count > 0:
new_vm_name = vm_name