ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-22 12:50:22 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Update bare exceptions to specify Exception.

Browse source 
This will keep us from accidentally catching program-exiting exceptions
like KeyboardInterupt and SystemExit.
This commit is contained in:
Toshio Kuratomi 2018-09-07 17:59:46 -07:00
commit 3fba006207
320 changed files with 659 additions and 656 deletions
Download patch file Download diff file Expand all files Collapse all files

14
lib/ansible/modules/storage/purestorage/purefb_snap.py
View file

@ -99,7 +99,7 @@ def get_fs(module, blade):
try:
res = blade.file_systems.list_file_systems(names=fs)
return res.items[0]
except:
except Exception:
return None
@ -109,7 +109,7 @@ def get_fssnapshot(module, blade):
filt = 'source=\'' + module.params['name'] + '\' and suffix=\'' + module.params['suffix'] + '\''
res = blade.file_system_snapshots.list_file_system_snapshots(filter=filt)
return res.items[0]
except:
except Exception:
return None
@ -121,7 +121,7 @@ def create_snapshot(module, blade):
try:
blade.file_system_snapshots.create_file_system_snapshots(sources=source, suffix=SnapshotSuffix(module.params['suffix']))
changed = True
except:
except Exception:
changed = False
module.exit_json(changed=changed)
@ -134,7 +134,7 @@ def recover_snapshot(module, blade):
try:
blade.file_system_snapshots.update_file_system_snapshots(name=snapname, attributes=new_attr)
changed = True
except:
except Exception:
changed = False
module.exit_json(changed=changed)
@ -157,9 +157,9 @@ def delete_snapshot(module, blade):
try:
blade.file_system_snapshots.delete_file_system_snapshots(name=snapname)
changed = True
except:
except Exception:
changed = False
except:
except Exception:
changed = False
module.exit_json(changed=changed)
@ -171,7 +171,7 @@ def eradicate_snapshot(module, blade):
try:
blade.file_system_snapshots.delete_file_system_snapshots(name=snapname)
changed = True
except:
except Exception:
changed = False
module.exit_json(changed=changed)