ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-22 12:50:22 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Update bare exceptions to specify Exception.

Browse source 
This will keep us from accidentally catching program-exiting exceptions
like KeyboardInterupt and SystemExit.
This commit is contained in:
Toshio Kuratomi 2018-09-07 17:59:46 -07:00
commit 3fba006207
320 changed files with 659 additions and 656 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/ansible/modules/storage/purestorage/purefb_s3acc.py
View file

@ -81,7 +81,7 @@ def create_s3acc(module, blade):
try:
blade.object_store_accounts.create_object_store_accounts(names=[module.params['name']])
changed = True
except:
except Exception:
module.fail_json(msg='Object Store Account {0}: Creation failed'.format(module.params['name']))
module.exit_json(changed=changed)
@ -96,7 +96,7 @@ def delete_s3acc(module, blade):
try:
blade.object_store_accounts.delete_object_store_accounts(names=[module.params['name']])
changed = True
except:
except Exception:
module.fail_json(msg='Object Store Account {0}: Deletion failed'.format(module.params['name']))
module.exit_json(changed=changed)