ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-22 21:00:22 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Update bare exceptions to specify Exception.

Browse source 
This will keep us from accidentally catching program-exiting exceptions
like KeyboardInterupt and SystemExit.
This commit is contained in:
Toshio Kuratomi 2018-09-07 17:59:46 -07:00
commit 3fba006207
320 changed files with 659 additions and 656 deletions
Download patch file Download diff file Expand all files Collapse all files

6
lib/ansible/modules/storage/purestorage/purefa_ra.py
View file

@ -65,14 +65,14 @@ def enable_ra(module, array):
ra_facts['fa_ra'] = {'name': ra_data['name'],
'port': ra_data['port']}
changed = True
except:
except Exception:
module.fail_json(msg='Enabling Remote Assist failed')
else:
try:
ra_data = array.get_remote_assist_status()
ra_facts['fa_ra'] = {'name': ra_data['name'],
'port': ra_data['port']}
except:
except Exception:
module.fail_json(msg='Getting Remote Assist failed')
module.exit_json(changed=changed, ansible_facts=ra_facts)
@ -84,7 +84,7 @@ def disable_ra(module, array):
try:
array.disable_remote_assist()
changed = True
except:
except Exception:
module.fail_json(msg='Disabling Remote Assist failed')
module.exit_json(changed=changed)