ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-22 12:50:22 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Update bare exceptions to specify Exception.

Browse source 
This will keep us from accidentally catching program-exiting exceptions
like KeyboardInterupt and SystemExit.
This commit is contained in:
Toshio Kuratomi 2018-09-07 17:59:46 -07:00
commit 3fba006207
320 changed files with 659 additions and 656 deletions
Download patch file Download diff file Expand all files Collapse all files

8
lib/ansible/modules/storage/purestorage/purefa_ds.py
View file

@ -158,7 +158,7 @@ def enable_ds(module, array):
try:
array.enable_directory_service()
changed = True
except:
except Exception:
module.fail_json(msg='Enable Directory Service failed: Check Configuration')
module.exit_json(changed=changed)
@ -170,7 +170,7 @@ def disable_ds(module, array):
try:
array.disable_directory_service()
changed = True
except:
except Exception:
module.fail_json(msg='Disable Directory Service failed')
module.exit_json(changed=changed)
@ -190,7 +190,7 @@ def delete_ds(module, array):
array_admin_group="",
certificate="")
changed = True
except:
except Exception:
module.fail_json(msg='Delete Directory Service failed')
module.exit_json(changed=changed)
@ -215,7 +215,7 @@ def create_ds(module, array):
array_admin_group=module.params['aa_group'])
array.set_directory_service(enabled=module.params['enable'])
changed = True
except:
except Exception:
module.fail_json(msg='Create Directory Service failed: Check configuration')
module.exit_json(changed=changed)