Update bare exceptions to specify Exception.

This will keep us from accidentally catching program-exiting exceptions
like KeyboardInterupt and SystemExit.
This commit is contained in:
Toshio Kuratomi 2018-09-07 17:59:46 -07:00
commit 3fba006207
320 changed files with 659 additions and 656 deletions

View file

@ -81,7 +81,7 @@ def delete_dns(module, array):
try:
array.set_dns(domain='', nameservers=[])
changed = True
except:
except Exception:
module.fail_json(msg='Delete DNS settigs failed')
module.exit_json(changed=changed)
@ -95,7 +95,7 @@ def create_dns(module, array):
array.set_dns(domain=module.params['domain'],
nameservers=module.params['nameservers'][0:3])
changed = True
except:
except Exception:
module.fail_json(msg='Set DNS settings failed: Check configuration')
module.exit_json(changed=changed)