ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-04-24 03:11:24 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Update bare exceptions to specify Exception.

Browse source 
This will keep us from accidentally catching program-exiting exceptions
like KeyboardInterupt and SystemExit.
This commit is contained in:
Toshio Kuratomi 2018-09-07 17:59:46 -07:00
parent 5147e792d3
commit 3fba006207
320 changed files with 659 additions and 656 deletions
Download patch file Download diff file Expand all files Collapse all files

8
lib/ansible/module_utils/redfish_utils.py
View file

@ -35,7 +35,7 @@ class RedfishUtils(object):
except URLError as e:
return {'ret': False, 'msg': "URL Error: %s" % e.reason}
# Almost all errors should be caught above, but just in case
except:
except Exception:
return {'ret': False, 'msg': "Unknown error"}
return {'ret': True, 'data': data}
@ -53,7 +53,7 @@ class RedfishUtils(object):
except URLError as e:
return {'ret': False, 'msg': "URL Error: %s" % e.reason}
# Almost all errors should be caught above, but just in case
except:
except Exception:
return {'ret': False, 'msg': "Unknown error"}
return {'ret': True, 'resp': resp}
@ -71,7 +71,7 @@ class RedfishUtils(object):
except URLError as e:
return {'ret': False, 'msg': "URL Error: %s" % e.reason}
# Almost all errors should be caught above, but just in case
except:
except Exception:
return {'ret': False, 'msg': "Unknown error"}
return {'ret': True, 'resp': resp}
@ -89,7 +89,7 @@ class RedfishUtils(object):
except URLError as e:
return {'ret': False, 'msg': "URL Error: %s" % e.reason}
# Almost all errors should be caught above, but just in case
except:
except Exception:
return {'ret': False, 'msg': "Unknown error"}
return {'ret': True, 'resp': resp}