ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-05-05 00:31:37 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

[PR #9881/e5eac9fe backport][stable-9] homebrew_cask: Handle unusual brew version strings (#9888)

Browse source 
homebrew_cask: Handle unusual brew version strings (#9881)

* Use regex to parse unusual brew version strings

Fixes: #8432

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
(cherry picked from commit e5eac9fed1)

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
This commit is contained in:
patchback[bot] 2025-03-15 09:22:42 +01:00 • committed by GitHub
parent 0dd960d8ab
commit 3bceabce93
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 36 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

37
tests/unit/plugins/modules/test_homebrew_cask.py
View file

@ -6,18 +6,33 @@ from __future__ import (absolute_import, division, print_function)
__metaclass__ = type
from ansible_collections.community.general.tests.unit.compat import unittest
from ansible_collections.community.general.plugins.modules.homebrew_cask import HomebrewCask
from ansible_collections.community.general.plugins.modules.homebrew_cask import (
HomebrewCask,
)
from ansible_collections.community.general.plugins.module_utils.homebrew import (
HomebrewValidate,
)
class TestHomebrewCaskModule(unittest.TestCase):
def test_valid_cask_names():
brew_cask_names = ["visual-studio-code", "firefox"]
for name in brew_cask_names:
assert HomebrewCask.valid_cask(name)
def setUp(self):
self.brew_cask_names = [
'visual-studio-code',
'firefox'
]
def test_valid_cask_names(self):
for name in self.brew_cask_names:
self.assertTrue(HomebrewCask.valid_cask(name))
def test_homebrew_version(mocker):
brew_versions = [
"Homebrew 4.1.0",
"Homebrew >=4.1.0 (shallow or no git repository)",
"Homebrew 4.1.0-dirty",
]
module = mocker.Mock()
mocker.patch.object(HomebrewCask, "valid_module", return_value=True)
mocker.patch.object(HomebrewValidate, "valid_path", return_value=True)
mocker.patch.object(HomebrewValidate, "valid_brew_path", return_value=True)
homebrewcask = HomebrewCask(module=module)
for version in brew_versions:
module.run_command.return_value = (0, version, "")
assert homebrewcask._get_brew_version() == "4.1.0"