ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-04-24 19:31:26 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

Fix from @jimi-c to use task_vars when polling async tasks. (#17003)

Browse source 
This is needed so that async_status can use ansible_python_interpreter
for the host being contacted.

Fixes #14101
This commit is contained in:
Toshio Kuratomi 2016-08-08 10:53:36 -07:00 • committed by GitHub
parent ab678738d6
commit 38ccd11cce
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
lib/ansible/executor/task_executor.py
View file

@ -468,7 +468,7 @@ class TaskExecutor:
if self._task.async > 0: if self._task.async > 0:
if self._task.poll > 0: if self._task.poll > 0:
result = self._poll_async_result(result=result, templar=templar) result = self._poll_async_result(result=result, templar=templar, task_vars=vars_copy)
# ensure no log is preserved # ensure no log is preserved
result["_ansible_no_log"] = self._play_context.no_log result["_ansible_no_log"] = self._play_context.no_log
@ -552,11 +552,14 @@ class TaskExecutor:
display.debug("attempt loop complete, returning result") display.debug("attempt loop complete, returning result")
return result return result
def _poll_async_result(self, result, templar): def _poll_async_result(self, result, templar, task_vars=None):
''' '''
Polls for the specified JID to be complete Polls for the specified JID to be complete
''' '''
if task_vars is None:
task_vars = self._job_vars
async_jid = result.get('ansible_job_id') async_jid = result.get('ansible_job_id')
if async_jid is None: if async_jid is None:
return dict(failed=True, msg="No job id was returned by the async task") return dict(failed=True, msg="No job id was returned by the async task")
@ -584,7 +587,7 @@ class TaskExecutor:
while time_left > 0: while time_left > 0:
time.sleep(self._task.poll) time.sleep(self._task.poll)
async_result = normal_handler.run() async_result = normal_handler.run(task_vars=task_vars)
# We do not bail out of the loop in cases where the failure # We do not bail out of the loop in cases where the failure
# is associated with a parsing error. The async_runner can # is associated with a parsing error. The async_runner can
# have issues which result in a half-written/unparseable result # have issues which result in a half-written/unparseable result