ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-04-29 22:01:27 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

Enable additional pylint rules and resolve issues found. (#47221)

Browse source 
* Resolve unneeded-not.
* Resolve global-at-module-level.
* Resolve useless-import-alias.
* Resolve bad-whitespace.
* Resolve global-variable-not-assigned.
* Resolve logging-not-lazy.
* Resolve comparison-with-itself.
This commit is contained in:
Matt Clay 2018-10-18 13:38:08 -07:00 • committed by GitHub
parent 77d32b8f57
commit 37b013aca3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
29 changed files with 42 additions and 53 deletions
Download patch file Download diff file Expand all files Collapse all files

16
test/units/module_utils/gcp/test_gcp_utils.py
View file

@ -29,7 +29,7 @@ class GCPRequestDifferenceTestCase(unittest.TestCase):
'test': 'original'
}
request = GcpRequest(value1)
self.assertEquals(request == request, True)
self.assertEquals(request, request)
def test_simple_different(self):
value1 = {
@ -45,7 +45,7 @@ class GCPRequestDifferenceTestCase(unittest.TestCase):
}
request1 = GcpRequest(value1)
request2 = GcpRequest(value2)
self.assertEquals(request1 == request2, False)
self.assertNotEquals(request1, request2)
self.assertEquals(request1.difference(request2), difference)
def test_nested_dictionaries_no_difference(self):
@ -59,7 +59,7 @@ class GCPRequestDifferenceTestCase(unittest.TestCase):
'test': 'original'
}
request = GcpRequest(value1)
self.assertEquals(request == request, True)
self.assertEquals(request, request)
def test_nested_dictionaries_with_difference(self):
value1 = {
@ -90,7 +90,7 @@ class GCPRequestDifferenceTestCase(unittest.TestCase):
}
request1 = GcpRequest(value1)
request2 = GcpRequest(value2)
self.assertEquals(request1 == request2, False)
self.assertNotEquals(request1, request2)
self.assertEquals(request1.difference(request2), difference)
def test_arrays_strings_no_difference(self):
@ -101,7 +101,7 @@ class GCPRequestDifferenceTestCase(unittest.TestCase):
]
}
request = GcpRequest(value1)
self.assertEquals(request == request, True)
self.assertEquals(request, request)
def test_arrays_strings_with_difference(self):
value1 = {
@ -124,7 +124,7 @@ class GCPRequestDifferenceTestCase(unittest.TestCase):
}
request1 = GcpRequest(value1)
request2 = GcpRequest(value2)
self.assertEquals(request1 == request2, False)
self.assertNotEquals(request1, request2)
self.assertEquals(request1.difference(request2), difference)
def test_arrays_dicts_with_no_difference(self):
@ -140,7 +140,7 @@ class GCPRequestDifferenceTestCase(unittest.TestCase):
]
}
request = GcpRequest(value1)
self.assertEquals(request == request, True)
self.assertEquals(request, request)
def test_arrays_dicts_with_difference(self):
value1 = {
@ -172,5 +172,5 @@ class GCPRequestDifferenceTestCase(unittest.TestCase):
}
request1 = GcpRequest(value1)
request2 = GcpRequest(value2)
self.assertEquals(request1 == request2, False)
self.assertNotEquals(request1, request2)
self.assertEquals(request1.difference(request2), difference)