mirror of
https://github.com/ansible-collections/community.general.git
synced 2025-07-22 12:50:22 -07:00
Prevent premature substitution of variables into tasks
As documented in #2623, early variable substitution causes when_
tests to fail and possibly other side effects.
I can see the reason for this early substitution, likely introduced
in 1dfe60a6
, to allow many playbook parameters to be templated.
This is a valid goal, but the recursive nature of the utils.template
function means that it goes too far.
At this point removing tasks from the list of parameters to be
substituted seems sufficient to make my tests pass. It may be the
case that other parameters should be excluded, but I suspect not.
Adding a test case. I would prefer to analyse not just the aggregate
statistics but also whether the results are as expected - I can't
see an easy way to do that with the available callbacks at present.
This commit is contained in:
parent
a05361f515
commit
377bc31311
3 changed files with 60 additions and 1 deletions
|
@ -65,7 +65,11 @@ class Play(object):
|
|||
|
||||
self._update_vars_files_for_host(None)
|
||||
|
||||
self._ds = ds = template.template(basedir, ds, self.vars)
|
||||
for key in ds:
|
||||
if key != 'tasks':
|
||||
ds[key] = template.template(basedir, ds[key], self.vars)
|
||||
|
||||
self._ds = ds
|
||||
|
||||
hosts = ds.get('hosts')
|
||||
if hosts is None:
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue