ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-04-23 10:51:24 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

Split basic units (#33510)

Browse source 
Split the one monolithic test for basic.py into several files

* Split test_basic.py along categories.
  This is preliminary to get a handle on things.  Eventually we may want
  to further split it so each file is only testing a single function.
* Cleanup unused imports from splitting test_basic.py
* Port atomic_move test to pytest.
  Working on getting rid of need to maintain procenv
* Split a test of symbolic_mode_to_octal to follow unittest best practices
  Each test should only invoke the function under test once
* Port test_argument_spec to pytest.
* Fix suboptions failure
This commit is contained in:
Toshio Kuratomi 2017-12-18 10:17:13 -08:00 • committed by GitHub
parent ba32827f3b
commit 370a7ace4b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
16 changed files with 1330 additions and 1359 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/ansible/module_utils/basic.py
View file

@ -1923,7 +1923,7 @@ class AnsibleModule(object):
wanted = v.get('type', None)
if wanted == 'dict' or (wanted == 'list' and v.get('elements', '') == 'dict'):
spec = v.get('options', None)
if spec is None or not params[k]:
if spec is None or k not in params or params[k] is None:
continue
self._options_context.append(k)