ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-09 14:50:02 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

docker_container: fix ipc_mode and pid_mode idempotency (#47997)

Browse source 
* Fix ipc_mode and pid_mode idempotency when container names are used.

* Add changelog.

* Update pid_mode documentation.
This commit is contained in:
Felix Fontein 2018-11-05 01:26:13 +01:00 • committed by Will Thames
parent 3cca4185be
commit 35809e99bc
3 changed files with 29 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

11
test/integration/targets/docker_container/tasks/tests/options.yml
View file

@ -1781,8 +1781,8 @@
command: '/bin/sh -c "sleep 10m"'
name: "{{ cname }}"
state: started
#ipc_mode: "container:{{ cname_h1 }}"
ipc_mode: shareable
ipc_mode: "container:{{ cname_h1 }}"
# ipc_mode: shareable
register: ipc_mode_1
- name: ipc_mode (idempotency)
@ -1791,9 +1791,8 @@
command: '/bin/sh -c "sleep 10m"'
name: "{{ cname }}"
state: started
# THIS IS CURRENTLY NOT IDEMPOTENT! SEE https://github.com/ansible/ansible/issues/45829
# ipc_mode: "container:{{ cname_h1 }}"
ipc_mode: shareable
ipc_mode: "container:{{ cname_h1 }}"
# ipc_mode: shareable
register: ipc_mode_2
- name: ipc_mode (change)
@ -2694,7 +2693,7 @@
command: '/bin/sh -c "sleep 10m"'
name: "{{ cname }}"
state: started
pid_mode: "container:{{ pid_mode_helper.ansible_facts.docker_container.Id }}"
pid_mode: "container:{{ cname_h1 }}"
register: pid_mode_2
ignore_errors: yes
# docker-py < 2.0 does not support "arbitrary" pid_mode values