expand user before calling abspath (#40196)

* expand user before calling abspath

* omit expanduser code smell check for volumes
This commit is contained in:
Ben Berry 2018-06-13 18:18:02 -07:00 committed by Brian Coca
parent 414aae70b1
commit 32c191ee9c
2 changed files with 5 additions and 4 deletions

View file

@ -844,14 +844,14 @@ class TaskParameters(DockerBaseClass):
if ':' in vol:
if len(vol.split(':')) == 3:
host, container, mode = vol.split(':')
if re.match(r'[\.~]', host):
host = os.path.abspath(host)
if re.match(r'[.~]', host):
host = os.path.abspath(os.path.expanduser(host))
new_vols.append("%s:%s:%s" % (host, container, mode))
continue
elif len(vol.split(':')) == 2:
parts = vol.split(':')
if parts[1] not in VOLUME_PERMISSIONS and re.match(r'[\.~]', parts[0]):
host = os.path.abspath(parts[0])
if parts[1] not in VOLUME_PERMISSIONS and re.match(r'[.~]', parts[0]):
host = os.path.abspath(os.path.expanduser(parts[0]))
new_vols.append("%s:%s:rw" % (host, parts[1]))
continue
new_vols.append(vol)