cloudstack: remove CloudStackException dep for several modules (#26874)

* cloudstack: cs_affinitygroup: remove CloudStackException dependency

* cloudstack: cs_domain: remove CloudStackException dependency

* cloudstack: cs_firewall: remove CloudStackException dependency

* cloudstack: cs_host: remove CloudStackException dependency

* cloudstack: cs_instancegroup: remove CloudStackException dependency

* cloudstack: cs_pod: remove CloudStackException dependency

* cloudstack: cs_configuration: remove CloudStackException dependency, fix pep8

* cloudstack: cs_cluster: remove CloudStackException dependency

* cloudstack: cs_network_acl: remove CloudStackException dependency

* cloudstack: cs_network_acl_rule: remove CloudStackException dependency

* cloudstack: cs_zone_facts: remove CloudStackException dependency

* cloudstack: cs_zone: remove CloudStackException dependency

* cloudstack: cs_vpn_gateway: remove CloudStackException dependency

* cloudstack: cs_vpc: remove CloudStackException dependency

* cloudstack: cs_sshkeypair: remove CloudStackException dependency

* cloudstack: cs_role: remove CloudStackException dependency

* cloudstack: cs_ip_address: remove CloudStackException dependency

* cloudstack: cs_ip_staticnat: remove CloudStackException dependency

* cloudstack: cs_resourcelimit: remove CloudStackException dependency

* cloudstack: cs_region: remove CloudStackException dependency

* cloudstack: cs_project: remove CloudStackException dependency

* cloudstack: cs_network: remove CloudStackException dependency

* cloudstack: cs_loadbalancer_rule_member: remove CloudStackException dependency

* cloudstack: cs_loadbalancer_rule: remove CloudStackException dependency

* cloudstack: cs_iso: remove CloudStackException dependency

lib/ansible/modules/cloud/cloudstack/cs_project.py

@@ -149,7 +149,6 @@ tags:
 from ansible.module_utils.basic import AnsibleModule
 from ansible.module_utils.cloudstack import (
     AnsibleCloudStack,
-    CloudStackException,
     cs_argument_spec,
     cs_required_together
 )
@@ -165,7 +164,7 @@ class AnsibleCloudStackProject(AnsibleCloudStack):
                 'account': self.get_account(key='name'),
                 'domainid': self.get_domain(key='id')
             }
-            projects = self.cs.listProjects(**args)
+            projects = self.query_api('listProjects', **args)
             if projects:
                 for p in projects['project']:
                     if project.lower() in [p['name'].lower(), p['id']]:
@@ -193,10 +192,7 @@ class AnsibleCloudStackProject(AnsibleCloudStack):
         if self.has_changed(args, project):
             self.result['changed'] = True
             if not self.module.check_mode:
-                project = self.cs.updateProject(**args)
-
-                if 'errortext' in project:
-                    self.module.fail_json(msg="Failed: '%s'" % project['errortext'])
+                project = self.query_api('updateProject', **args)
 
                 poll_async = self.module.params.get('poll_async')
                 if project and poll_async:
@@ -213,10 +209,7 @@ class AnsibleCloudStackProject(AnsibleCloudStack):
             'domainid': self.get_domain('id')
         }
         if not self.module.check_mode:
-            project = self.cs.createProject(**args)
-
-            if 'errortext' in project:
-                self.module.fail_json(msg="Failed: '%s'" % project['errortext'])
+            project = self.query_api('createProject', **args)
 
             poll_async = self.module.params.get('poll_async')
             if project and poll_async:
@@ -234,12 +227,9 @@ class AnsibleCloudStackProject(AnsibleCloudStack):
             }
             if not self.module.check_mode:
                 if state == 'suspended':
-                    project = self.cs.suspendProject(**args)
+                    project = self.query_api('suspendProject', **args)
                 else:
-                    project = self.cs.activateProject(**args)
-
-                if 'errortext' in project:
-                    self.module.fail_json(msg="Failed: '%s'" % project['errortext'])
+                    project = self.query_api('activateProject', **args)
 
                 poll_async = self.module.params.get('poll_async')
                 if project and poll_async:
@@ -255,10 +245,7 @@ class AnsibleCloudStackProject(AnsibleCloudStack):
                 'id': project['id']
             }
             if not self.module.check_mode:
-                res = self.cs.deleteProject(**args)
-
-                if 'errortext' in res:
-                    self.module.fail_json(msg="Failed: '%s'" % res['errortext'])
+                res = self.query_api('deleteProject', **args)
 
                 poll_async = self.module.params.get('poll_async')
                 if res and poll_async:
@@ -284,24 +271,19 @@ def main():
         supports_check_mode=True
     )
 
-    try:
-        acs_project = AnsibleCloudStackProject(module)
+    acs_project = AnsibleCloudStackProject(module)
 
-        state = module.params.get('state')
-        if state in ['absent']:
-            project = acs_project.absent_project()
+    state = module.params.get('state')
+    if state in ['absent']:
+        project = acs_project.absent_project()
 
-        elif state in ['active', 'suspended']:
-            project = acs_project.state_project(state=state)
+    elif state in ['active', 'suspended']:
+        project = acs_project.state_project(state=state)
 
-        else:
-            project = acs_project.present_project()
-
-        result = acs_project.get_result(project)
-
-    except CloudStackException as e:
-        module.fail_json(msg='CloudStackException: %s' % str(e))
+    else:
+        project = acs_project.present_project()
 
+    result = acs_project.get_result(project)
     module.exit_json(**result)