mirror of
https://github.com/ansible-collections/community.general.git
synced 2025-07-08 22:30:04 -07:00
[proxmox_template] Fix error while uploading big ISO to Proxmox VE cluster (#6757)
* [proxmox_template] Fix error while uploading big ISO to Proxmox VE cluster * Fix pep8 test * Add changelog fragment * Add notes about requests_toolbelt * Check versions and file size * Fix typo in notes * Add unit test. Move try inside of each function. * Fix sanity tests * Add proxmoxer in requirements file * Update integration tests * Add proxmoxer into constraints.txt * Address review comments * Don't run tests on 2.6 python * Disable Python 2.6 tests for other proxmox modules
This commit is contained in:
parent
867704dd75
commit
2d6e369d81
10 changed files with 299 additions and 34 deletions
6
tests/integration/targets/proxmox_template/aliases
Normal file
6
tests/integration/targets/proxmox_template/aliases
Normal file
|
@ -0,0 +1,6 @@
|
|||
# Copyright (c) Ansible Project
|
||||
# GNU General Public License v3.0+ (see LICENSES/GPL-3.0-or-later.txt or https://www.gnu.org/licenses/gpl-3.0.txt)
|
||||
# SPDX-License-Identifier: GPL-3.0-or-later
|
||||
|
||||
unsupported
|
||||
proxmox_template
|
136
tests/integration/targets/proxmox_template/tasks/main.yml
Normal file
136
tests/integration/targets/proxmox_template/tasks/main.yml
Normal file
|
@ -0,0 +1,136 @@
|
|||
####################################################################
|
||||
# WARNING: These are designed specifically for Ansible tests #
|
||||
# and should not be used as examples of how to write Ansible roles #
|
||||
####################################################################
|
||||
|
||||
# Copyright (c) 2023, Sergei Antipov <greendayonfire at gmail.com>
|
||||
# GNU General Public License v3.0+ (see LICENSES/GPL-3.0-or-later.txt or https://www.gnu.org/licenses/gpl-3.0.txt)
|
||||
# SPDX-License-Identifier: GPL-3.0-or-later
|
||||
|
||||
- name: Proxmox VE virtual machines templates management
|
||||
tags: ['template']
|
||||
vars:
|
||||
filename: /tmp/dummy.iso
|
||||
block:
|
||||
- name: Create dummy ISO file
|
||||
ansible.builtin.command:
|
||||
cmd: 'truncate -s 300M {{ filename }}'
|
||||
|
||||
- name: Delete requests_toolbelt module if it is installed
|
||||
ansible.builtin.pip:
|
||||
name: requests_toolbelt
|
||||
state: absent
|
||||
|
||||
- name: Install latest proxmoxer
|
||||
ansible.builtin.pip:
|
||||
name: proxmoxer
|
||||
state: latest
|
||||
|
||||
- name: Upload ISO as template to Proxmox VE cluster should fail
|
||||
proxmox_template:
|
||||
api_host: '{{ api_host }}'
|
||||
api_user: '{{ user }}@{{ domain }}'
|
||||
api_password: '{{ api_password | default(omit) }}'
|
||||
api_token_id: '{{ api_token_id | default(omit) }}'
|
||||
api_token_secret: '{{ api_token_secret | default(omit) }}'
|
||||
validate_certs: '{{ validate_certs }}'
|
||||
node: '{{ node }}'
|
||||
src: '{{ filename }}'
|
||||
content_type: iso
|
||||
force: true
|
||||
register: result
|
||||
ignore_errors: true
|
||||
|
||||
- assert:
|
||||
that:
|
||||
- result is failed
|
||||
- result.msg is match('\'requests_toolbelt\' module is required to upload files larger than 256MB')
|
||||
|
||||
- name: Install old (1.1.2) version of proxmoxer
|
||||
ansible.builtin.pip:
|
||||
name: proxmoxer==1.1.1
|
||||
state: present
|
||||
|
||||
- name: Upload ISO as template to Proxmox VE cluster should be successful
|
||||
proxmox_template:
|
||||
api_host: '{{ api_host }}'
|
||||
api_user: '{{ user }}@{{ domain }}'
|
||||
api_password: '{{ api_password | default(omit) }}'
|
||||
api_token_id: '{{ api_token_id | default(omit) }}'
|
||||
api_token_secret: '{{ api_token_secret | default(omit) }}'
|
||||
validate_certs: '{{ validate_certs }}'
|
||||
node: '{{ node }}'
|
||||
src: '{{ filename }}'
|
||||
content_type: iso
|
||||
force: true
|
||||
register: result
|
||||
|
||||
- assert:
|
||||
that:
|
||||
- result is changed
|
||||
- result is success
|
||||
- result.msg is match('template with volid=local:iso/dummy.iso uploaded')
|
||||
|
||||
- name: Install latest proxmoxer
|
||||
ansible.builtin.pip:
|
||||
name: proxmoxer
|
||||
state: latest
|
||||
|
||||
- name: Make smaller dummy file
|
||||
ansible.builtin.command:
|
||||
cmd: 'truncate -s 128M {{ filename }}'
|
||||
|
||||
- name: Upload ISO as template to Proxmox VE cluster should be successful
|
||||
proxmox_template:
|
||||
api_host: '{{ api_host }}'
|
||||
api_user: '{{ user }}@{{ domain }}'
|
||||
api_password: '{{ api_password | default(omit) }}'
|
||||
api_token_id: '{{ api_token_id | default(omit) }}'
|
||||
api_token_secret: '{{ api_token_secret | default(omit) }}'
|
||||
validate_certs: '{{ validate_certs }}'
|
||||
node: '{{ node }}'
|
||||
src: '{{ filename }}'
|
||||
content_type: iso
|
||||
force: true
|
||||
register: result
|
||||
|
||||
- assert:
|
||||
that:
|
||||
- result is changed
|
||||
- result is success
|
||||
- result.msg is match('template with volid=local:iso/dummy.iso uploaded')
|
||||
|
||||
- name: Install requests_toolbelt
|
||||
ansible.builtin.pip:
|
||||
name: requests_toolbelt
|
||||
state: present
|
||||
|
||||
- name: Make big dummy file
|
||||
ansible.builtin.command:
|
||||
cmd: 'truncate -s 300M {{ filename }}'
|
||||
|
||||
- name: Upload ISO as template to Proxmox VE cluster should be successful
|
||||
proxmox_template:
|
||||
api_host: '{{ api_host }}'
|
||||
api_user: '{{ user }}@{{ domain }}'
|
||||
api_password: '{{ api_password | default(omit) }}'
|
||||
api_token_id: '{{ api_token_id | default(omit) }}'
|
||||
api_token_secret: '{{ api_token_secret | default(omit) }}'
|
||||
validate_certs: '{{ validate_certs }}'
|
||||
node: '{{ node }}'
|
||||
src: '{{ filename }}'
|
||||
content_type: iso
|
||||
force: true
|
||||
register: result
|
||||
|
||||
- assert:
|
||||
that:
|
||||
- result is changed
|
||||
- result is success
|
||||
- result.msg is match('template with volid=local:iso/dummy.iso uploaded')
|
||||
|
||||
always:
|
||||
- name: Delete ISO file from host
|
||||
ansible.builtin.file:
|
||||
path: '{{ filename }}'
|
||||
state: absent
|
Loading…
Add table
Add a link
Reference in a new issue