ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-24 05:40:23 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Tidy up sanity checks ignore lines modules (batch 7) (#1970)

Browse source 
* fixed validation-modules for plugins/modules/cloud/heroku/heroku_collaborator.py

* fixed validation-modules for plugins/modules/cloud/linode/linode_v4.py

* fixed validation-modules for plugins/modules/remote_management/manageiq/manageiq_provider.py

* fixed validation-modules for plugins/modules/remote_management/manageiq/manageiq_policies.py

* fixed validation-modules for plugins/modules/remote_management/manageiq/manageiq_alert_profiles.py

* fixed validation-modules for plugins/modules/remote_management/manageiq/manageiq_tags.py

* fixed validation-modules for plugins/modules/cloud/opennebula/one_host.py

* fixed validation-modules for plugins/modules/cloud/opennebula/one_image_info.py

* fixed validation-modules for plugins/modules/cloud/opennebula/one_vm.py

* fixed validation-modules for plugins/modules/cloud/scaleway/scaleway_lb.py

* fixed validation-modules for plugins/modules/cloud/scaleway/scaleway_compute.py

* fixed validation-modules for plugins/modules/remote_management/oneview/oneview_network_set_info.py

* fixed validation-modules for plugins/modules/remote_management/oneview/oneview_ethernet_network_info.py

* fixed validation-modules for plugins/modules/remote_management/oneview/oneview_datacenter_info.py

* fixed validation-modules for plugins/modules/remote_management/oneview/oneview_enclosure_info.py

* Tidy up sanity checks ignore lines modules (batch 7)

* added changelog fragment

* Missed a couple of lines in ingnore-2.11.txt

* fixed validation-modules for plugins/modules/cloud/packet/packet_volume_attachment.py

* Adjusted ignore files and changelog for packet_volume_attachment.py

* Rolled back ignore line for linode module

* Update plugins/modules/cloud/opennebula/one_image_info.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* fixes from the PR

Co-authored-by: Felix Fontein <felix@fontein.de>
This commit is contained in:
Alexei Znamensky 2021-03-08 20:35:09 +13:00 • committed by GitHub
commit 2906591c08
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
20 changed files with 85 additions and 75 deletions
Download patch file Download diff file Expand all files Collapse all files

3
plugins/modules/cloud/heroku/heroku_collaborator.py
View file

@ -26,6 +26,7 @@ options:
- Heroku API key
apps:
type: list
elements: str
description:
- List of Heroku App names
required: true
@ -109,7 +110,7 @@ def main():
argument_spec = HerokuHelper.heroku_argument_spec()
argument_spec.update(
user=dict(required=True, type='str'),
apps=dict(required=True, type='list'),
apps=dict(required=True, type='list', elements='str'),
suppress_invitation=dict(default=False, type='bool'),
state=dict(default='present', type='str', choices=['present', 'absent']),
)

6
plugins/modules/cloud/linode/linode_v4.py
View file

@ -63,6 +63,7 @@ options:
U(https://www.linode.com/docs/api/tags/).
required: false
type: list
elements: str
root_pass:
description:
- The password for the root user. If not specified, one will be
@ -75,6 +76,7 @@ options:
- A list of SSH public key parts to deploy for the root user.
required: false
type: list
elements: str
state:
description:
- The desired instance state.
@ -240,12 +242,12 @@ def initialise_module():
no_log=True,
fallback=(env_fallback, ['LINODE_ACCESS_TOKEN']),
),
authorized_keys=dict(type='list', required=False),
authorized_keys=dict(type='list', elements='str', required=False),
group=dict(type='str', required=False),
image=dict(type='str', required=False),
region=dict(type='str', required=False),
root_pass=dict(type='str', required=False, no_log=True),
tags=dict(type='list', required=False),
tags=dict(type='list', elements='str', required=False),
type=dict(type='str', required=False),
stackscript_id=dict(type='int', required=False),
stackscript_data=dict(type='dict', required=False),

3
plugins/modules/cloud/opennebula/one_host.py
View file

@ -66,6 +66,7 @@ options:
description:
- The labels for this host.
type: list
elements: str
template:
description:
- The template or attribute changes to merge into the host template.
@ -130,7 +131,7 @@ class HostModule(OpenNebulaModule):
vmm_mad_name=dict(type='str', default="kvm"),
cluster_id=dict(type='int', default=0),
cluster_name=dict(type='str'),
labels=dict(type='list'),
labels=dict(type='list', elements='str'),
template=dict(type='dict', aliases=['attributes']),
)

11
plugins/modules/cloud/opennebula/one_image_info.py
View file

@ -56,6 +56,7 @@ options:
- A list of images ids whose facts you want to gather.
aliases: ['id']
type: list
elements: str
name:
description:
- A C(name) of the image whose facts will be gathered.
@ -253,7 +254,7 @@ def main():
"api_url": {"required": False, "type": "str"},
"api_username": {"required": False, "type": "str"},
"api_password": {"required": False, "type": "str", "no_log": True},
"ids": {"required": False, "aliases": ['id'], "type": "list"},
"ids": {"required": False, "aliases": ['id'], "type": "list", "elements": "str"},
"name": {"required": False, "type": "str"},
}
@ -273,9 +274,6 @@ def main():
name = params.get('name')
client = pyone.OneServer(auth.url, session=auth.username + ':' + auth.password)
result = {'images': []}
images = []
if ids:
images = get_images_by_ids(module, client, ids)
elif name:
@ -283,8 +281,9 @@ def main():
else:
images = get_all_images(client).IMAGE
for image in images:
result['images'].append(get_image_info(image))
result = {
'images': [get_image_info(image) for image in images],
}
module.exit_json(**result)

15
plugins/modules/cloud/opennebula/one_vm.py
View file

@ -72,6 +72,7 @@ options:
- A list of instance ids used for states':' C(absent), C(running), C(rebooted), C(poweredoff)
aliases: ['ids']
type: list
elements: int
state:
description:
- C(present) - create instances from a template specified with C(template_id)/C(template_name).
@ -120,6 +121,7 @@ options:
- C(state) of instances with these labels.
default: []
type: list
elements: str
count_attributes:
description:
- A dictionary of key/value attributes that can only be used with
@ -134,6 +136,7 @@ options:
- This can be expressed in multiple ways and is shown in the EXAMPLES
- section.
type: list
elements: str
count:
description:
- Number of instances to launch
@ -168,6 +171,7 @@ options:
- NOTE':' If The Template hats Multiple Disks the Order of the Sizes is
- matched against the order specified in C(template_id)/C(template_name).
type: list
elements: str
cpu:
description:
- Percentage of CPU divided by 100 required for the new instance. Half a
@ -182,6 +186,7 @@ options:
- A list of dictionaries with network parameters. See examples for more details.
default: []
type: list
elements: dict
disk_saveas:
description:
- Creates an image from a VM disk.
@ -1349,7 +1354,7 @@ def main():
"api_url": {"required": False, "type": "str"},
"api_username": {"required": False, "type": "str"},
"api_password": {"required": False, "type": "str", "no_log": True},
"instance_ids": {"required": False, "aliases": ['ids'], "type": "list"},
"instance_ids": {"required": False, "aliases": ['ids'], "type": "list", "elements": "int"},
"template_name": {"required": False, "type": "str"},
"template_id": {"required": False, "type": "int"},
"vm_start_on_hold": {"default": False, "type": "bool"},
@ -1367,16 +1372,16 @@ def main():
"memory": {"required": False, "type": "str"},
"cpu": {"required": False, "type": "float"},
"vcpu": {"required": False, "type": "int"},
"disk_size": {"required": False, "type": "list"},
"disk_size": {"required": False, "type": "list", "elements": "str"},
"datastore_name": {"required": False, "type": "str"},
"datastore_id": {"required": False, "type": "int"},
"networks": {"default": [], "type": "list"},
"networks": {"default": [], "type": "list", "elements": "dict"},
"count": {"default": 1, "type": "int"},
"exact_count": {"required": False, "type": "int"},
"attributes": {"default": {}, "type": "dict"},
"count_attributes": {"required": False, "type": "dict"},
"labels": {"default": [], "type": "list"},
"count_labels": {"required": False, "type": "list"},
"labels": {"default": [], "type": "list", "elements": "str"},
"count_labels": {"required": False, "type": "list", "elements": "str"},
"disk_saveas": {"type": "dict"},
"persistent": {"default": False, "type": "bool"}
}

1
plugins/modules/cloud/packet/packet_volume_attachment.py
View file

@ -181,7 +181,6 @@ def do_detach(packet_conn, vol, dev_id=None):
return (dev_id is None) or (a['device']['id'] == dev_id)
for a in vol['attachments']:
if dev_match(a):
print(a['href'])
packet_conn.call_api(a['href'], type="DELETE")

3
plugins/modules/cloud/scaleway/scaleway_compute.py
View file

@ -70,6 +70,7 @@ options:
tags:
type: list
elements: str
description:
- List of tags to apply to the instance (5 max)
required: false
@ -652,7 +653,7 @@ def main():
enable_ipv6=dict(default=False, type="bool"),
public_ip=dict(default="absent"),
state=dict(choices=list(state_strategy.keys()), default='present'),
tags=dict(type="list", default=[]),
tags=dict(type="list", elements="str", default=[]),
organization=dict(required=True),
wait=dict(type="bool", default=False),
wait_timeout=dict(type="int", default=300),

3
plugins/modules/cloud/scaleway/scaleway_lb.py
View file

@ -63,6 +63,7 @@ options:
tags:
type: list
elements: str
description:
- List of tags to apply to the load-balancer
@ -338,7 +339,7 @@ def main():
description=dict(required=True),
region=dict(required=True, choices=SCALEWAY_REGIONS),
state=dict(choices=list(state_strategy.keys()), default='present'),
tags=dict(type="list", default=[]),
tags=dict(type="list", elements="str", default=[]),
organization_id=dict(required=True),
wait=dict(type="bool", default=False),
wait_timeout=dict(type="int", default=300),