ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-04-25 03:41:25 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

network command modules cleanup (#45242)

Browse source 
* Standardize _command modules

* Centralize command transformation process

* Fix check mode error test
This commit is contained in:
Nathaniel Case 2018-09-13 08:55:35 -04:00 • committed by GitHub
parent df768914a1
commit 285b927889
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
11 changed files with 115 additions and 204 deletions
Download patch file Download diff file Expand all files Collapse all files

16
lib/ansible/modules/network/junos/junos_command.py
View file

@ -158,16 +158,17 @@ failed_conditions:
type: list
sample: ['...', '...']
"""
import time
import re
import shlex
import time
from ansible.module_utils.basic import AnsibleModule
from ansible.module_utils._text import to_text
from ansible.module_utils.basic import AnsibleModule
from ansible.module_utils.connection import ConnectionError
from ansible.module_utils.network.common.netconf import exec_rpc
from ansible.module_utils.network.junos.junos import junos_argument_spec, get_configuration, get_connection, get_capabilities, tostring
from ansible.module_utils.network.common.parsing import Conditional, FailedConditionalError
from ansible.module_utils.network.common.utils import to_lines
from ansible.module_utils.six import string_types, iteritems
@ -185,15 +186,6 @@ except ImportError:
USE_PERSISTENT_CONNECTION = True
def to_lines(stdout):
lines = list()
for item in stdout:
if isinstance(item, string_types):
item = str(item).split('\n')
lines.append(item)
return lines
def rpc(module, items):
responses = list()
@ -438,7 +430,7 @@ def main():
'changed': False,
'warnings': warnings,
'stdout': responses,
'stdout_lines': to_lines(responses)
'stdout_lines': list(to_lines(responses)),
}
if output: