Remove deprecated features, bump version to 6.0.0 (#5326)

* Bump version to 6.0.0.

* sender option is now required.

* Default of want_proxmox_nodes_ansible_host changed from true to false.

* username is now an alias of user, and no longer of workspace.

* Remove deprecated return values in favor of end_state.

* Remove debug option.

* Change default of ignore_volatile_options from true to false.

* gitlab_group must now always contain the full path.

* Change default of norc from false to ture.

* Remove deprecated property.

* Add PR URL.

* Adjust bitbucket unit tests.

* Adjust module_helper integration test.

plugins/modules/source_control/bitbucket/bitbucket_access_key.py

@@ -27,10 +27,9 @@ options:
   workspace:
     description:
       - The repository owner.
-      - Alias I(username) has been deprecated and will become an alias of I(user) in community.general 6.0.0.
+      - I(username) used to be an alias of this option. Since community.general 6.0.0 it is an alias of I(user).
     type: str
     required: true
-    aliases: [ username ]
   key:
     description:
       - The SSH public key.
@@ -218,8 +217,7 @@ def main():
     argument_spec.update(
         repository=dict(type='str', required=True),
         workspace=dict(
-            type='str', aliases=['username'], required=True,
-            deprecated_aliases=[dict(name='username', version='6.0.0', collection_name='community.general')],
+            type='str', required=True,
         ),
         key=dict(type='str', no_log=False),
         label=dict(type='str', required=True),

plugins/modules/source_control/bitbucket/bitbucket_pipeline_key_pair.py

@@ -27,10 +27,9 @@ options:
   workspace:
     description:
       - The repository owner.
-      - Alias I(username) has been deprecated and will become an alias of I(user) in community.general 6.0.0.
+      - I(username) used to be an alias of this option. Since community.general 6.0.0 it is an alias of I(user).
     type: str
     required: true
-    aliases: [ username ]
   public_key:
     description:
       - The public key.
@@ -154,10 +153,7 @@ def main():
     argument_spec = BitbucketHelper.bitbucket_argument_spec()
     argument_spec.update(
         repository=dict(type='str', required=True),
-        workspace=dict(
-            type='str', aliases=['username'], required=True,
-            deprecated_aliases=[dict(name='username', version='6.0.0', collection_name='community.general')],
-        ),
+        workspace=dict(type='str', required=True),
         public_key=dict(type='str'),
         private_key=dict(type='str', no_log=True),
         state=dict(type='str', choices=['present', 'absent'], required=True),

plugins/modules/source_control/bitbucket/bitbucket_pipeline_known_host.py

@@ -30,10 +30,9 @@ options:
   workspace:
     description:
       - The repository owner.
-      - Alias I(username) has been deprecated and will become an alias of I(user) in community.general 6.0.0.
+      - I(username) used to be an alias of this option. Since community.general 6.0.0 it is an alias of I(user).
     type: str
     required: true
-    aliases: [ username ]
   name:
     description:
       - The FQDN of the known host.
@@ -255,10 +254,7 @@ def main():
     argument_spec = BitbucketHelper.bitbucket_argument_spec()
     argument_spec.update(
         repository=dict(type='str', required=True),
-        workspace=dict(
-            type='str', aliases=['username'], required=True,
-            deprecated_aliases=[dict(name='username', version='6.0.0', collection_name='community.general')],
-        ),
+        workspace=dict(type='str', required=True),
         name=dict(type='str', required=True),
         key=dict(type='str', no_log=False),
         state=dict(type='str', choices=['present', 'absent'], required=True),

plugins/modules/source_control/bitbucket/bitbucket_pipeline_variable.py

@@ -27,10 +27,9 @@ options:
   workspace:
     description:
       - The repository owner.
-      - Alias I(username) has been deprecated and will become an alias of I(user) in community.general 6.0.0.
+      - I(username) used to be an alias of this option. Since community.general 6.0.0 it is an alias of I(user).
     type: str
     required: true
-    aliases: [ username ]
   name:
     description:
       - The pipeline variable name.
@@ -215,10 +214,7 @@ def main():
     argument_spec = BitbucketHelper.bitbucket_argument_spec()
     argument_spec.update(
         repository=dict(type='str', required=True),
-        workspace=dict(
-            type='str', aliases=['username'], required=True,
-            deprecated_aliases=[dict(name='username', version='6.0.0', collection_name='community.general')],
-        ),
+        workspace=dict(type='str', required=True),
         name=dict(type='str', required=True),
         value=dict(type='str'),
         secured=dict(type='bool', default=False),

plugins/modules/source_control/gitlab/gitlab_group_members.py

@@ -27,7 +27,7 @@ options:
   gitlab_group:
     description:
       - The C(full_path) of the GitLab group the member is added to/removed from.
-      - Setting this to C(name) or C(path) is deprecated and will be removed in community.general 6.0.0. Use C(full_path) instead.
+      - Setting this to C(name) or C(path) has been disallowed since community.general 6.0.0. Use C(full_path) instead.
     required: true
     type: str
   gitlab_user:
@@ -176,12 +176,6 @@ class GitLabGroup(object):
         for group in groups:
             if group.full_path == gitlab_group:
                 return group.id
-        for group in groups:
-            if group.path == gitlab_group or group.name == gitlab_group:
-                self._module.deprecate(
-                    msg="Setting 'gitlab_group' to 'name' or 'path' is deprecated. Use 'full_path' instead",
-                    version="6.0.0", collection_name="community.general")
-                return group.id
 
     # get all members in a group
     def get_members_in_a_group(self, gitlab_group_id):