Normalize bools in tests (#5996)

* Normalize bools in tests.

* Fix typo.
This commit is contained in:
Felix Fontein 2023-02-15 22:55:23 +01:00 committed by GitHub
commit 24efe9ee9a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
182 changed files with 770 additions and 770 deletions

View file

@ -18,10 +18,10 @@
- name: Install iptables (SuSE only)
package:
name: iptables
become: yes
become: true
when: ansible_os_family == 'Suse'
- name: Install ufw
become: yes
become: true
package:
name: ufw
@ -30,7 +30,7 @@
- include_tasks: run-test.yml
with_fileglob:
- "tests/*.yml"
become: yes
become: true
# Cleanup
always:

View file

@ -10,7 +10,7 @@
- name: Enable (check mode)
ufw:
state: enabled
check_mode: yes
check_mode: true
register: enable_check
- name: Enable
ufw:
@ -23,7 +23,7 @@
- name: Enable (idempotency, check mode)
ufw:
state: enabled
check_mode: yes
check_mode: true
register: enable_idem_check
- assert:
that:
@ -38,7 +38,7 @@
rule: allow
port: 23
to_ip: 0.0.0.0
check_mode: yes
check_mode: true
register: ipv4_allow_check
- name: ipv4 allow
ufw:
@ -57,7 +57,7 @@
rule: allow
port: 23
to_ip: 0.0.0.0
check_mode: yes
check_mode: true
register: ipv4_allow_idem_check
- assert:
that:
@ -72,30 +72,30 @@
rule: allow
port: 23
to_ip: 0.0.0.0
delete: yes
check_mode: yes
delete: true
check_mode: true
register: delete_ipv4_allow_check
- name: delete ipv4 allow
ufw:
rule: allow
port: 23
to_ip: 0.0.0.0
delete: yes
delete: true
register: delete_ipv4_allow
- name: delete ipv4 allow (idempotency)
ufw:
rule: allow
port: 23
to_ip: 0.0.0.0
delete: yes
delete: true
register: delete_ipv4_allow_idem
- name: delete ipv4 allow (idempotency, check mode)
ufw:
rule: allow
port: 23
to_ip: 0.0.0.0
delete: yes
check_mode: yes
delete: true
check_mode: true
register: delete_ipv4_allow_idem_check
- assert:
that:
@ -110,7 +110,7 @@
rule: allow
port: 23
to_ip: "::"
check_mode: yes
check_mode: true
register: ipv6_allow_check
- name: ipv6 allow
ufw:
@ -129,7 +129,7 @@
rule: allow
port: 23
to_ip: "::"
check_mode: yes
check_mode: true
register: ipv6_allow_idem_check
- assert:
that:
@ -144,30 +144,30 @@
rule: allow
port: 23
to_ip: "::"
delete: yes
check_mode: yes
delete: true
check_mode: true
register: delete_ipv6_allow_check
- name: delete ipv6 allow
ufw:
rule: allow
port: 23
to_ip: "::"
delete: yes
delete: true
register: delete_ipv6_allow
- name: delete ipv6 allow (idempotency)
ufw:
rule: allow
port: 23
to_ip: "::"
delete: yes
delete: true
register: delete_ipv6_allow_idem
- name: delete ipv6 allow (idempotency, check mode)
ufw:
rule: allow
port: 23
to_ip: "::"
delete: yes
check_mode: yes
delete: true
check_mode: true
register: delete_ipv6_allow_idem_check
- assert:
that:
@ -183,7 +183,7 @@
rule: allow
port: 23
to_ip: 0.0.0.0
check_mode: yes
check_mode: true
register: ipv4_allow_check
- name: ipv4 allow
ufw:
@ -202,7 +202,7 @@
rule: allow
port: 23
to_ip: 0.0.0.0
check_mode: yes
check_mode: true
register: ipv4_allow_idem_check
- assert:
that:
@ -217,30 +217,30 @@
rule: allow
port: 23
to_ip: 0.0.0.0
delete: yes
check_mode: yes
delete: true
check_mode: true
register: delete_ipv4_allow_check
- name: delete ipv4 allow
ufw:
rule: allow
port: 23
to_ip: 0.0.0.0
delete: yes
delete: true
register: delete_ipv4_allow
- name: delete ipv4 allow (idempotency)
ufw:
rule: allow
port: 23
to_ip: 0.0.0.0
delete: yes
delete: true
register: delete_ipv4_allow_idem
- name: delete ipv4 allow (idempotency, check mode)
ufw:
rule: allow
port: 23
to_ip: 0.0.0.0
delete: yes
check_mode: yes
delete: true
check_mode: true
register: delete_ipv4_allow_idem_check
- assert:
that:
@ -255,7 +255,7 @@
rule: allow
port: 23
to_ip: "::"
check_mode: yes
check_mode: true
register: ipv6_allow_check
- name: ipv6 allow
ufw:
@ -274,7 +274,7 @@
rule: allow
port: 23
to_ip: "::"
check_mode: yes
check_mode: true
register: ipv6_allow_idem_check
- assert:
that:
@ -289,30 +289,30 @@
rule: allow
port: 23
to_ip: "::"
delete: yes
check_mode: yes
delete: true
check_mode: true
register: delete_ipv6_allow_check
- name: delete ipv6 allow
ufw:
rule: allow
port: 23
to_ip: "::"
delete: yes
delete: true
register: delete_ipv6_allow
- name: delete ipv6 allow (idempotency)
ufw:
rule: allow
port: 23
to_ip: "::"
delete: yes
delete: true
register: delete_ipv6_allow_idem
- name: delete ipv6 allow (idempotency, check mode)
ufw:
rule: allow
port: 23
to_ip: "::"
delete: yes
check_mode: yes
delete: true
check_mode: true
register: delete_ipv6_allow_idem_check
- assert:
that:
@ -329,7 +329,7 @@
- name: Reload ufw (check mode)
ufw:
state: reloaded
check_mode: yes
check_mode: true
register: reload_check
- assert:
that:
@ -340,7 +340,7 @@
- name: Disable (check mode)
ufw:
state: disabled
check_mode: yes
check_mode: true
register: disable_check
- name: Disable
ufw:
@ -353,7 +353,7 @@
- name: Disable (idempotency, check mode)
ufw:
state: disabled
check_mode: yes
check_mode: true
register: disable_idem_check
- assert:
that:
@ -369,7 +369,7 @@
- name: Reset (check mode)
ufw:
state: reset
check_mode: yes
check_mode: true
register: reset_check
- pause:
# Should not be needed, but since ufw is ignoring --dry-run for reset
@ -396,7 +396,7 @@
- name: Reset (idempotency, check mode)
ufw:
state: reset
check_mode: yes
check_mode: true
register: reset_idem_check
- assert:
that:

View file

@ -10,15 +10,15 @@
# ############################################
- name: Make sure logging is off
ufw:
logging: no
logging: false
- name: Logging (check mode)
ufw:
logging: yes
check_mode: yes
logging: true
check_mode: true
register: logging_check
- name: Logging
ufw:
logging: yes
logging: true
register: logging
- name: Get logging
shell: |
@ -28,17 +28,17 @@
LC_ALL: C
- name: Logging (idempotency)
ufw:
logging: yes
logging: true
register: logging_idem
- name: Logging (idempotency, check mode)
ufw:
logging: yes
check_mode: yes
logging: true
check_mode: true
register: logging_idem_check
- name: Logging (change, check mode)
ufw:
logging: full
check_mode: yes
check_mode: true
register: logging_change_check
- name: Logging (change)
ufw:
@ -66,7 +66,7 @@
ufw:
default: reject
direction: incoming
check_mode: yes
check_mode: true
register: default_check
- name: Default
ufw:
@ -88,13 +88,13 @@
ufw:
default: reject
direction: incoming
check_mode: yes
check_mode: true
register: default_idem_check
- name: Default (change, check mode)
ufw:
default: allow
direction: incoming
check_mode: yes
check_mode: true
register: default_change_check
- name: Default (change)
ufw:
@ -115,7 +115,7 @@
- name: Default (change incoming implicitly, check mode)
ufw:
default: allow
check_mode: yes
check_mode: true
register: default_change_implicit_check
- name: Default (change incoming implicitly)
ufw:
@ -130,7 +130,7 @@
- name: Default (change incoming implicitly, idempotent, check mode)
ufw:
default: allow
check_mode: yes
check_mode: true
register: default_change_implicit_idem_check
- name: Default (change incoming implicitly, idempotent)
ufw:

View file

@ -10,7 +10,7 @@
- name: Route with interface in and out
ufw:
rule: allow
route: yes
route: true
interface_in: foo
interface_out: bar
proto: tcp
@ -22,7 +22,7 @@
- name: Route with interface in
ufw:
rule: allow
route: yes
route: true
interface_in: foo
proto: tcp
from_ip: 1.1.1.1
@ -31,7 +31,7 @@
- name: Route with interface out
ufw:
rule: allow
route: yes
route: true
interface_out: bar
proto: tcp
from_ip: 1.1.1.1
@ -77,7 +77,7 @@
from_port: 1111
to_ip: 8.8.8.8
to_port: 2222
ignore_errors: yes
ignore_errors: true
register: ufw_non_route_iface
- assert: