Normalize bools in tests (#5996)

* Normalize bools in tests.

* Fix typo.

tests/integration/targets/launchd/tasks/setup.yml

@@ -7,7 +7,7 @@
   template:
     src: "{{ launchd_service_name }}.plist.j2"
     dest: "{{ launchd_plist_location }}"
-  become: yes
+  become: true
 
 - name: install the test daemon script
   copy:
@@ -20,4 +20,4 @@
     path: /usr/local/sbin/ansible_test_service
     line: "#!{{ ansible_python_interpreter | realpath }}"
     insertbefore: BOF
-    firstmatch: yes
+    firstmatch: true

tests/integration/targets/launchd/tasks/teardown.yml

@@ -7,7 +7,7 @@
   launchd:
     name: "{{ launchd_service_name }}"
     state: unloaded
-  become: yes
+  become: true
   register: launchd_unloaded_result
 
 - name: "[{{ item }}] Validation"
@@ -21,10 +21,10 @@
   file:
     path: "{{ launchd_plist_location }}"
     state: absent
-  become: yes
+  become: true
 
 - name: "[{{ item }}] Remove test service server"
   file:
     path: "/usr/local/sbin/ansible_test_service"
     state: absent
-  become: yes
+  become: true

tests/integration/targets/launchd/tasks/tests/test_reload.yml

@@ -9,9 +9,9 @@
   launchd:
     name: "{{ launchd_service_name }}"
     state: started
-  become: yes
+  become: true
   register: "test_1_launchd_start_result_check_mode"
-  check_mode: yes
+  check_mode: true
 
 - name: "[{{ item }}] Assert that everything work in check mode"
   assert:
@@ -23,7 +23,7 @@
   launchd:
     name: "{{ launchd_service_name }}"
     state: started
-  become: yes
+  become: true
   register: "test_1_launchd_start_result"
 
 
@@ -37,13 +37,13 @@
   template:
     src: "modified.{{ launchd_service_name }}.plist.j2"
     dest: "{{ launchd_plist_location }}"
-  become: yes
+  become: true
 
 - name: "[{{ item }}] When reloading the service..."
   launchd:
     name: "{{ launchd_service_name }}"
     state: reloaded
-  become: yes
+  become: true
   register: "test_1_launchd_reload_result"
 
 - name: "[{{ item }}] Validate that service was reloaded"
@@ -60,7 +60,7 @@
   launchd:
     name: "{{ launchd_service_name }}"
     state: started
-  become: yes
+  become: true
   register: "test_1_launchd_start_result"
 
 

tests/integration/targets/launchd/tasks/tests/test_restart.yml

@@ -9,7 +9,7 @@
   launchd:
     name: "{{ launchd_service_name }}"
     state: started
-  become: yes
+  become: true
   register: "test_1_launchd_start_result"
 
 
@@ -17,9 +17,9 @@
   launchd:
     name: "{{ launchd_service_name }}"
     state: restarted
-  become: yes
+  become: true
   register: "test_1_launchd_restart_result_check_mode"
-  check_mode: yes
+  check_mode: true
 
 - name: "[{{ item }}] Validate that service was restarted in check mode"
   assert:
@@ -31,7 +31,7 @@
   launchd:
     name: "{{ launchd_service_name }}"
     state: restarted
-  become: yes
+  become: true
   register: "test_1_launchd_restart_result"
 
 - name: "[{{ item }}] Validate that service was restarted"

tests/integration/targets/launchd/tasks/tests/test_runatload.yml

@@ -9,8 +9,8 @@
   launchd:
     name: "{{ launchd_service_name }}"
     state: started
-    enabled: yes
-  become: yes
+    enabled: true
+  become: true
   register: test_1_launchd_start_result
 
 - name: "[{{ item }}] Validate that service was started"
@@ -31,6 +31,6 @@
       \s+<key>RunAtLoad</key>
       \s+<true/>
     replace: found_run_at_load
-  check_mode: yes
+  check_mode: true
   register: contents_would_have
   failed_when: not contents_would_have is changed

tests/integration/targets/launchd/tasks/tests/test_start_stop.yml

@@ -9,9 +9,9 @@
   launchd:
     name: "{{ launchd_service_name }}"
     state: started
-  become: yes
+  become: true
   register: "test_1_launchd_start_result_check_mode"
-  check_mode: yes
+  check_mode: true
 
 
 - name: "[{{ item }}] Validate that service was started in check mode"
@@ -25,7 +25,7 @@
   launchd:
     name: "{{ launchd_service_name }}"
     state: started
-  become: yes
+  become: true
   register: "test_1_launchd_start_result"
 
 
@@ -46,7 +46,7 @@
   launchd:
     name: "{{ launchd_service_name }}"
     state: stopped
-  become: yes
+  become: true
   register: "test_2_launchd_stop_result"
 
 - name: "[{{ item }}] Validate that service was stopped after it was started"
@@ -65,7 +65,7 @@
   launchd:
     name: "{{ launchd_service_name }}"
     state: stopped
-  become: yes
+  become: true
   register: "test_3_launchd_stop_result"
 
 - name: "[{{ item }}] Validate that service can be stopped after being already stopped"
@@ -84,7 +84,7 @@
   launchd:
     name: "{{ launchd_service_name }}"
     state: started
-  become: yes
+  become: true
   register: "test_4_launchd_start_result"
 
 - name: "[{{ item }}] Validate that service was started..."
@@ -102,7 +102,7 @@
   launchd:
     name: "{{ launchd_service_name }}"
     state: started
-  become: yes
+  become: true
   register: "test_5_launchd_start_result"
 
 - name: "[{{ item }}] Validate that service is still in the same state as before"

tests/integration/targets/launchd/tasks/tests/test_unload.yml

@@ -9,7 +9,7 @@
   launchd:
     name: "{{ launchd_service_name }}"
     state: started
-  become: yes
+  become: true
   register: "test_1_launchd_start_result"
 
 
@@ -17,9 +17,9 @@
   launchd:
     name: "{{ launchd_service_name }}"
     state: unloaded
-  become: yes
+  become: true
   register: "test_1_launchd_unloaded_result_check_mode"
-  check_mode: yes
+  check_mode: true
 
 - name: "[{{ item }}] Validate that service was unloaded in check mode"
   assert:
@@ -32,7 +32,7 @@
   launchd:
     name: "{{ launchd_service_name }}"
     state: unloaded
-  become: yes
+  become: true
   register: "test_1_launchd_unloaded_result"
 
 - name: "[{{ item }}] Validate that service was unloaded"
@@ -51,7 +51,7 @@
   launchd:
     name: "{{ launchd_service_name }}"
     state: unloaded
-  become: yes
+  become: true
   register: "test_2_launchd_unloaded_result"
 
 - name: "[{{ item }}] Validate that service did not change and is still unloaded"