ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-10-08 01:14:03 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Eliminate redundant module argument checks.

Browse source
This commit is contained in:
Ash Wilson 2015-02-23 14:33:02 -06:00 • committed by Matt Clay
commit 23c79ed474
5 changed files with 4 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

6
lib/ansible/modules/extras/cloud/rackspace/rax_mon_entity.py
View file

@ -83,8 +83,6 @@ except ImportError:
def cloud_monitoring(module, state, label, agent_id, named_ip_addresses,
metadata):
if not label:
module.fail_json(msg='label is required for rax_mon_entity')
if len(label) < 1 or len(label) > 255:
module.fail_json(msg='label must be between 1 and 255 characters long')
@ -139,13 +137,11 @@ def cloud_monitoring(module, state, label, agent_id, named_ip_addresses,
ip_addresses=named_ip_addresses,
metadata=metadata)
changed = True
elif state == 'absent':
else:
# Delete the existing Entities.
for e in existing:
e.delete()
changed = True
else:
module.fail_json(msg='state must be present or absent')
if entity:
entity_dict = {