ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-05-30 12:59:09 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Eliminate redundant module argument checks.

Browse source
This commit is contained in:
Ash Wilson 2015-02-23 14:33:02 -06:00 • committed by Matt Clay
parent 6b753c5c71
commit 23c79ed474
5 changed files with 4 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

15
lib/ansible/modules/extras/cloud/rackspace/rax_mon_alarm.py
View file

@ -105,17 +105,6 @@ except ImportError:
def alarm(module, state, label, entity_id, check_id, notification_plan_id, criteria,
disabled, metadata):
# Verify the presence of required attributes.
required_attrs = {
"label": label, "entity_id": entity_id, "check_id": check_id,
"notification_plan_id": notification_plan_id
}
for (key, value) in required_attrs.iteritems():
if not value:
module.fail_json(msg=('%s is required for rax_mon_alarm' % key))
if len(label) < 1 or len(label) > 255:
module.fail_json(msg='label must be between 1 and 255 characters long')
@ -173,12 +162,10 @@ def alarm(module, state, label, entity_id, check_id, notification_plan_id, crite
criteria=criteria, disabled=disabled, label=label,
metadata=metadata)
changed = True
elif state == 'absent':
else:
for a in existing:
a.delete()
changed = True
else:
module.fail_json(msg='state must be either present or absent.')
if alarm:
alarm_dict = {