ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-05-07 17:51:29 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

ANSIBLE_SSH_USETTY configuration option (#33148)

Browse source 
* Allow the user to circumvent adding -tt on ssh commands to help aid in
debugging ssh related problems.
* Move config to the plugin
* Set version_added
* Change yaml section to "connection"
* Fix ssh unit tests
This commit is contained in:
jctanner 2017-11-22 11:19:43 -05:00 • committed by GitHub
parent aa42a2680e
commit 218987eac1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 26 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
test/units/plugins/connection/test_ssh.py
View file

@ -80,6 +80,8 @@ class TestConnectionBaseClass(unittest.TestCase):
conn._build_command.return_value = 'ssh something something'
conn._run = MagicMock()
conn._run.return_value = (0, 'stdout', 'stderr')
conn.get_option = MagicMock()
conn.get_option.return_value = True
res, stdout, stderr = conn.exec_command('ssh')
res, stdout, stderr = conn.exec_command('ssh', 'this is some data')
@ -538,6 +540,8 @@ class TestSSHConnectionRetries(object):
self.conn._build_command = MagicMock()
self.conn._build_command.return_value = 'ssh'
self.conn.get_option = MagicMock()
self.conn.get_option.return_value = True
return_code, b_stdout, b_stderr = self.conn.exec_command('ssh', 'some data')
assert return_code == 0
@ -563,6 +567,8 @@ class TestSSHConnectionRetries(object):
self.conn._build_command = MagicMock()
self.conn._build_command.return_value = 'ssh'
self.conn.get_option = MagicMock()
self.conn.get_option.return_value = True
pytest.raises(AnsibleConnectionFailure, self.conn.exec_command, 'ssh', 'some data')
assert self.mock_popen.call_count == 10
@ -575,6 +581,8 @@ class TestSSHConnectionRetries(object):
self.conn._build_command = MagicMock()
self.conn._build_command.return_value = 'ssh'
self.conn.get_option = MagicMock()
self.conn.get_option.return_value = True
self.mock_popen.side_effect = [Exception('bad')] * 10
pytest.raises(Exception, self.conn.exec_command, 'ssh', 'some data')