ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-22 12:50:22 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

VMware: check if folder already exists before creation (#41588)

Browse source 
* check if folder already exists before creation
* added integration test
This commit is contained in:
Orr 2018-07-30 08:41:42 +03:00 • committed by Abhijeet Kasurde
commit 1e4831e744
2 changed files with 22 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
lib/ansible/modules/cloud/vmware/vcenter_folder.py
View file

@ -158,12 +158,12 @@ class VmwareFolderManager(PyVmomi):
try:
if parent_folder:
folder = self.get_folder_by_name(folder_name=parent_folder)
if folder:
if folder and not self.get_folder_by_name(folder_name=folder_name, parent_folder=folder):
folder.CreateFolder(folder_name)
results['changed'] = True
results['result'] = "Folder '%s' of type '%s' created under %s" \
" successfully." % (folder_name, folder_type, parent_folder)
else:
elif folder is None:
self.module.fail_json(msg="Failed to find the parent folder %s"
" for folder %s" % (parent_folder, folder_name))
else:
@ -208,13 +208,13 @@ class VmwareFolderManager(PyVmomi):
" exception %s " % to_native(e))
self.module.exit_json(**results)
def get_folder_by_name(self, folder_name):
def get_folder_by_name(self, folder_name, parent_folder=None):
"""
Function to get managed object of folder by name
Returns: Managed object of folder by name
"""
folder_objs = get_all_objs(self.content, [vim.Folder])
folder_objs = get_all_objs(self.content, [vim.Folder], parent_folder)
for folder in folder_objs:
if folder.name == folder_name:
return folder