mirror of
https://github.com/ansible-collections/community.general.git
synced 2025-07-23 05:10:22 -07:00
Performance improvement using in-operator on dicts
Just a small cleanup for the existing occurrences. Using the in-operator for hash lookups is faster than using .keys() http://stackoverflow.com/questions/29314269/why-do-key-in-dict-and-key-in-dict-keys-have-the-same-output
This commit is contained in:
parent
b79bf14607
commit
1ca4add91c
7 changed files with 15 additions and 15 deletions
|
@ -268,12 +268,12 @@ class Task(Base, Conditional, Taggable, Become):
|
|||
else:
|
||||
env = []
|
||||
for env_item in value:
|
||||
if isinstance(env_item, (string_types, AnsibleUnicode)) and env_item in templar._available_variables.keys():
|
||||
if isinstance(env_item, (string_types, AnsibleUnicode)) and env_item in templar._available_variables:
|
||||
env[env_item] = templar.template(env_item, convert_bare=False)
|
||||
elif isinstance(value, dict):
|
||||
env = dict()
|
||||
for env_item in value:
|
||||
if isinstance(env_item, (string_types, AnsibleUnicode)) and env_item in templar._available_variables.keys():
|
||||
if isinstance(env_item, (string_types, AnsibleUnicode)) and env_item in templar._available_variables:
|
||||
env[env_item] = templar.template(value[env_item], convert_bare=False)
|
||||
|
||||
# at this point it should be a simple string
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue