ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-23 13:20:23 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

lvg: Add parameter to disable removal of extra physical volumes (#9698)

Browse source 
* Add parameter to disable removal of extra physical volumes

Signed-off-by: Massl123 <Massl123@users.noreply.github.com>

* Set PR number in changelog fragment

Signed-off-by: Massl123 <Massl123@users.noreply.github.com>

* Fix tests

Signed-off-by: Massl123 <Massl123@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* Add comment in pvs

Signed-off-by: Massl123 <Massl123@users.noreply.github.com>

---------

Signed-off-by: Massl123 <Massl123@users.noreply.github.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
This commit is contained in:
Marcel Freundl 2025-02-10 21:51:45 +01:00 • committed by GitHub
commit 1beee87961
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 56 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/integration/targets/lvg/tasks/main.yml
View file

@ -24,6 +24,8 @@
- import_tasks: test_grow_reduce.yml
- import_tasks: test_remove_extra_pvs.yml
- import_tasks: test_pvresize.yml
- import_tasks: test_active_change.yml

40
tests/integration/targets/lvg/tasks/test_remove_extra_pvs.yml Normal file
View file

@ -0,0 +1,40 @@
---
# Copyright (c) Ansible Project
# GNU General Public License v3.0+ (see LICENSES/GPL-3.0-or-later.txt or https://www.gnu.org/licenses/gpl-3.0.txt)
# SPDX-License-Identifier: GPL-3.0-or-later
# test_grow_reduce already checks the base case with default parameters (remove additional PVs)
- name: "Create volume group on first disk"
lvg:
vg: testvg
pvs: "{{ loop_device1 }}"
- name: "get lvm facts"
setup:
- debug: var=ansible_lvm
- name: "Assert the testvg span only on first disk"
assert:
that:
- ansible_lvm.pvs[loop_device1].vg == "testvg"
- 'loop_device2 not in ansible_lvm.pvs or
ansible_lvm.pvs[loop_device2].vg == ""'
- name: "Extend to second disk AND keep first disk"
lvg:
vg: testvg
pvs: "{{ loop_device2 }}"
remove_extra_pvs: false
- name: "get lvm facts"
setup:
- debug: var=ansible_lvm
- name: "Assert the testvg spans on both disks"
assert:
that:
- ansible_lvm.pvs[loop_device1].vg == "testvg"
- ansible_lvm.pvs[loop_device2].vg == "testvg"