ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-08-20 04:51:43 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

java_keystore: fix keystore type (#2516)

Browse source 
* fix keystore type; update unit tests

* add changelog fragment

* document new param 'keystore_type'

* add keystore_type support (backward compatible)

* check JKS format with magic bytes
* update integration tests
* revert first changes in unit tests
* update changelog fragment

* fix magic bytes for python2/python3

* fix integration tests (irrelevant check_mode)

* fix unit test (keystore removed before failure => changed=true)

* fix typo

* fix spelling

* shorten a branch

* mock is_jks_or_pkcs12

* fix function path in unit tests

* Apply suggestions from code review (spelling)

Co-authored-by: Ajpantuso <ajpantuso@gmail.com>

* rename a method (module + unit tests)

* move ArgumentSpec class content to main()

* refactor create() to not loose existing keystore in case of error

* update unit tests

* add integration test (error handling)

* fix keystore backup cleanup

Co-authored-by: Ajpantuso <ajpantuso@gmail.com>
This commit is contained in:
quidame 2021-06-27 14:56:43 +02:00 • committed by GitHub
commit 199ead85d0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 308 additions and 69 deletions
Download patch file Download diff file Expand all files Collapse all files

4
changelogs/fragments/2516_fix_2515_keystore_type_jks.yml Normal file
View file

@ -0,0 +1,4 @@
---
bugfixes:
- "java_keystore - add parameter ``keystore_type`` to control output file format and override ``keytool``'s
default, which depends on Java version (https://github.com/ansible-collections/community.general/issues/2515)."