From 17e7b71776f7e0347c3bbdafbb712745b012b4fe Mon Sep 17 00:00:00 2001 From: Alexei Znamensky <103110+russoz@users.noreply.github.com> Date: Thu, 17 Jul 2025 15:01:42 +1200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Felix Fontein --- plugins/modules/keycloak_client_rolemapping.py | 4 ++-- plugins/modules/keycloak_user.py | 2 +- plugins/modules/keycloak_userprofile.py | 1 - 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/plugins/modules/keycloak_client_rolemapping.py b/plugins/modules/keycloak_client_rolemapping.py index c28951f791..1700c99cc1 100644 --- a/plugins/modules/keycloak_client_rolemapping.py +++ b/plugins/modules/keycloak_client_rolemapping.py @@ -39,9 +39,9 @@ options: state: description: - State of the client_rolemapping. - - On V(present), the client_rolemapping __FIXME__(will) be created if it does not yet exist, or updated with the parameters + - On V(present), the client_rolemapping is created if it does not yet exist, or updated with the parameters you provide. - - On V(absent), the client_rolemapping __FIXME__(will) be removed if it exists. + - On V(absent), the client_rolemapping is removed if it exists. default: 'present' type: str choices: diff --git a/plugins/modules/keycloak_user.py b/plugins/modules/keycloak_user.py index 8c9d8bb023..02eb226a4d 100644 --- a/plugins/modules/keycloak_user.py +++ b/plugins/modules/keycloak_user.py @@ -103,7 +103,7 @@ options: - List of groups for the user. - Groups can be referenced by their name, like V(staff), or their path, like V(/staff/engineering). The path syntax allows you to reference subgroups, which is not possible otherwise. - - This is possible since community.general 10.6.0. + - Using the path is possible since community.general 10.6.0. type: list elements: dict default: [] diff --git a/plugins/modules/keycloak_userprofile.py b/plugins/modules/keycloak_userprofile.py index e2c7079bb5..81594de5c3 100644 --- a/plugins/modules/keycloak_userprofile.py +++ b/plugins/modules/keycloak_userprofile.py @@ -405,7 +405,6 @@ data: description: The data returned by the Keycloak API. returned: when state is present type: dict - sample: {"...": "..."} """ from ansible_collections.community.general.plugins.module_utils.identity.keycloak.keycloak import KeycloakAPI, camel, \