From 179e2882f7e183d75236d1f098795aafb8395c81 Mon Sep 17 00:00:00 2001 From: Takuya Sato Date: Fri, 14 Jul 2017 09:10:31 +0900 Subject: [PATCH] ecs_taskdefinition module: containers.environment convert to string (fix #23297) (#23681) It is to fix the failed comparison of containers. --- lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py b/lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py index 9dea5af1c6..dc8cd8edc1 100644 --- a/lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py +++ b/lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py @@ -241,6 +241,11 @@ def main(): task_mgr = EcsTaskManager(module) results = dict(changed=False) + for container in module.params['containers']: + if 'environment' in container: + for environment in container['environment']: + environment['value'] = str(environment['value']) + if module.params['state'] == 'present': if 'containers' not in module.params or not module.params['containers']: module.fail_json(msg="To use task definitions, a list of containers must be specified") @@ -353,10 +358,6 @@ def main(): if not module.check_mode: # Doesn't exist. create it. volumes = module.params.get('volumes', []) or [] - for container in module.params['containers']: - if 'environment' in container: - for environment in container['environment']: - environment['value'] = str(environment['value']) results['taskdefinition'] = task_mgr.register_task(module.params['family'], module.params['task_role_arn'], module.params['network_mode'],