ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-10-12 03:14:24 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Ensure that current uses of BaseException are required

Browse source 
* In some cases, it appears that Exception should have been used instead
  as there's no need to catch sys.exit KeyboardInterrupt and similar.
* In a few cases, it appears that BaseException is used because
  a library we depend on calls sys.exit() contrary to good coding
  design.  Comment those so that we know that those have been audited
  and found to be correct and change to use (Exception, SystemExit)
  instead.
This commit is contained in:
Toshio Kuratomi 2018-09-09 22:16:05 -07:00
commit 175f3b51e5
9 changed files with 31 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

2
test/sanity/import/importer.py
View file

@ -99,6 +99,8 @@ def test_python_module(path, base_dir, messages, ansible_module):
except ImporterAnsibleModuleException:
# module instantiated AnsibleModule without raising an exception
pass
# We truly want to catch anything the plugin might do here, including call sys.exit() so we
# catch BaseException
except BaseException as ex: # pylint: disable=locally-disabled, broad-except
capture_report(path, capture, messages)