ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-05-02 15:21:25 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

fixes minor bugs in eos_eapi module (#21925)

Browse source 
* module will now check protocol running state before return
* warns on config argument no longer being needed
* lots of integration test cases updated
* updates unit and integration test cases for state check

fixes #21908
This commit is contained in:
Peter Sprygada 2017-02-25 17:18:46 -05:00 • committed by GitHub
parent 7c3957cc0c
commit 16a39639f5
6 changed files with 95 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

21
test/units/modules/network/eos/test_eos_eapi.py
View file

@ -39,12 +39,22 @@ class TestEosEapiModule(TestEosModule):
self.mock_load_config = patch('ansible.modules.network.eos.eos_eapi.load_config')
self.load_config = self.mock_load_config.start()
self.mock_verify_state = patch('ansible.modules.network.eos.eos_eapi.verify_state')
self.verify_state = self.mock_verify_state.start()
self.command_fixtures = {}
def tearDown(self):
self.mock_run_commands.stop()
self.mock_load_config.stop()
# hack for older version of mock
# should be using patch.stopall() but CI is still failing
try:
self.mock_verify_state.stop()
except RuntimeError:
pass
def load_fixtures(self, commands=None):
def run_commands(module, commands, **kwargs):
output = list()
@ -137,3 +147,14 @@ class TestEosEapiModule(TestEosModule):
commands = ['management api http-commands', 'shutdown']
self.start_configured(changed=True, commands=commands)
def test_eos_eapi_state_failed(self):
self.mock_verify_state.stop()
set_module_args(dict(state='stopped', timeout=1))
result = self.start_configured(failed=True)
'timeout expired before eapi running state changed' in result['msg']
def test_eos_eapi_state_failed(self):
self.mock_verify_state.stop()
set_module_args(dict(state='stopped', timeout=1))
result = self.start_configured(failed=True)
'timeout expired before eapi running state changed' in result['msg']