ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-10-09 18:04:02 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

cloudstack: use paging for listVirtualMachines (#40018)

Browse source 
Paging wasn't implemented, so once a cs domain has over 500 (default page size) VMs, Ansible can no longer find newly created VM.
This commit is contained in:
Peter Farmer 2018-05-12 08:46:49 +01:00 • committed by René Moser
commit 16994bbdca
5 changed files with 12 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

3
lib/ansible/modules/cloud/cloudstack/cs_instance.py
View file

@ -457,11 +457,12 @@ class AnsibleCloudStackInstance(AnsibleCloudStack):
'account': self.get_account(key='name'),
'domainid': self.get_domain(key='id'),
'projectid': self.get_project(key='id'),
'fetch_list': True,
}
# Do not pass zoneid, as the instance name must be unique across zones.
instances = self.query_api('listVirtualMachines', **args)
if instances:
for v in instances['virtualmachine']:
for v in instances:
if instance_name.lower() in [v['name'].lower(), v['displayname'].lower(), v['id']]:
self.instance = v
break

3
lib/ansible/modules/cloud/cloudstack/cs_instance_facts.py
View file

@ -206,11 +206,12 @@ class AnsibleCloudStackInstanceFacts(AnsibleCloudStack):
'account': self.get_account(key='name'),
'domainid': self.get_domain(key='id'),
'projectid': self.get_project(key='id'),
'fetch_list': True,
}
# Do not pass zoneid, as the instance name must be unique across zones.
instances = self.query_api('listVirtualMachines', **args)
if instances:
for v in instances['virtualmachine']:
for v in instances:
if instance_name.lower() in [v['name'].lower(), v['displayname'].lower(), v['id']]:
self.instance = v
break

3
lib/ansible/modules/cloud/cloudstack/cs_loadbalancer_rule_member.py
View file

@ -269,10 +269,11 @@ class AnsibleCloudStackLBRuleMember(AnsibleCloudStack):
return rule
args = self._get_common_args()
args['fetch_list'] = True
vms = self.query_api('listVirtualMachines', **args)
to_change_ids = []
for name in to_change:
for vm in vms.get('virtualmachine', []):
for vm in vms:
if vm['name'] == name:
to_change_ids.append(vm['id'])
break