updates eos modules to use socket (#21197)

* updates eos modules to use persistent connection socket
* removes split eos shared module and combines into one
* adds singular eos doc frag (eos_local to be removed after module updates)
* updates unit test cases
This commit is contained in:
Peter Sprygada 2017-02-13 20:22:10 -05:00 committed by GitHub
parent 9937e604f5
commit 14b942f3fb
23 changed files with 837 additions and 1348 deletions

View file

@ -21,50 +21,16 @@
from __future__ import (absolute_import, division, print_function)
__metaclass__ = type
import os
import sys
import json
from ansible.compat.tests import unittest
from ansible.compat.tests.mock import patch, MagicMock
from ansible.errors import AnsibleModuleExit
from ansible.compat.tests.mock import patch
from ansible.modules.network.eos import eos_config
from ansible.module_utils.netcfg import NetworkConfig
from ansible.module_utils import basic
from ansible.module_utils._text import to_bytes
PROVIDER_ARGS = {
'host': 'localhost',
'username': 'username',
'password': 'password'
}
def set_module_args(args):
args = json.dumps({'ANSIBLE_MODULE_ARGS': args})
basic._ANSIBLE_ARGS = to_bytes(args)
fixture_path = os.path.join(os.path.dirname(__file__), 'fixtures')
fixture_data = {}
def load_fixture(name):
path = os.path.join(fixture_path, name)
if path in fixture_data:
return fixture_data[path]
with open(path) as f:
data = f.read()
try:
data = json.loads(data)
except:
pass
fixture_data[path] = data
return data
from .eos_module import TestEosModule, load_fixture, set_module_args
class TestEosConfigModule(unittest.TestCase):
class TestEosConfigModule(TestEosModule):
module = eos_config
def setUp(self):
self.mock_get_config = patch('ansible.modules.network.eos.eos_config.get_config')
@ -73,40 +39,21 @@ class TestEosConfigModule(unittest.TestCase):
self.mock_load_config = patch('ansible.modules.network.eos.eos_config.load_config')
self.load_config = self.mock_load_config.start()
self.mock_supports_sessions = patch('ansible.modules.network.eos.eos_config.supports_sessions')
self.supports_sessions = self.mock_supports_sessions.start()
self.supports_sessions.return_value = True
def tearDown(self):
self.mock_get_config.stop()
self.mock_load_config.stop()
def execute_module(self, failed=False, changed=False):
def load_fixtures(self, commands=None):
self.get_config.return_value = load_fixture('eos_config_config.cfg')
self.load_config.return_value = dict(diff=None, session='session')
with self.assertRaises(AnsibleModuleExit) as exc:
eos_config.main()
result = exc.exception.result
if failed:
self.assertTrue(result.get('failed'))
else:
self.assertEqual(result.get('changed'), changed, result)
return result
def test_eos_config_no_change(self):
args = dict(lines=['hostname localhost'])
args.update(PROVIDER_ARGS)
set_module_args(args)
result = self.execute_module()
def test_eos_config_src(self):
args = dict(src=load_fixture('eos_config_candidate.cfg'))
args.update(PROVIDER_ARGS)
set_module_args(args)
result = self.execute_module(changed=True)
@ -117,7 +64,6 @@ class TestEosConfigModule(unittest.TestCase):
def test_eos_config_lines(self):
args = dict(lines=['hostname switch01', 'ip domain-name eng.ansible.com'])
args.update(PROVIDER_ARGS)
set_module_args(args)
result = self.execute_module(changed=True)
@ -129,7 +75,6 @@ class TestEosConfigModule(unittest.TestCase):
args = dict(lines=['hostname switch01', 'ip domain-name eng.ansible.com'],
before=['before command'])
args.update(PROVIDER_ARGS)
set_module_args(args)
result = self.execute_module(changed=True)
@ -142,7 +87,6 @@ class TestEosConfigModule(unittest.TestCase):
args = dict(lines=['hostname switch01', 'ip domain-name eng.ansible.com'],
after=['after command'])
args.update(PROVIDER_ARGS)
set_module_args(args)
result = self.execute_module(changed=True)
@ -153,7 +97,6 @@ class TestEosConfigModule(unittest.TestCase):
def test_eos_config_parents(self):
args = dict(lines=['ip address 1.2.3.4/5', 'no shutdown'], parents=['interface Ethernet10'])
args.update(PROVIDER_ARGS)
set_module_args(args)
result = self.execute_module(changed=True)
@ -163,37 +106,31 @@ class TestEosConfigModule(unittest.TestCase):
def test_eos_config_src_and_lines_fails(self):
args = dict(src='foo', lines='foo')
args.update(PROVIDER_ARGS)
set_module_args(args)
result = self.execute_module(failed=True)
def test_eos_config_match_exact_requires_lines(self):
args = dict(match='exact')
args.update(PROVIDER_ARGS)
set_module_args(args)
result = self.execute_module(failed=True)
def test_eos_config_match_strict_requires_lines(self):
args = dict(match='strict')
args.update(PROVIDER_ARGS)
set_module_args(args)
result = self.execute_module(failed=True)
def test_eos_config_replace_block_requires_lines(self):
args = dict(replace='block')
args.update(PROVIDER_ARGS)
set_module_args(args)
result = self.execute_module(failed=True)
def test_eos_config_replace_config_requires_src(self):
args = dict(replace='config')
args.update(PROVIDER_ARGS)
set_module_args(args)
result = self.execute_module(failed=True)
def test_eos_config_backup_returns__backup__(self):
args = dict(backup=True)
args.update(PROVIDER_ARGS)
set_module_args(args)
result = self.execute_module()
self.assertIn('__backup__', result)