From 10561e6f302c40a734b8c9a91b3a5d39a570c375 Mon Sep 17 00:00:00 2001 From: "patchback[bot]" <45432694+patchback[bot]@users.noreply.github.com> Date: Mon, 11 Nov 2024 20:13:27 +0100 Subject: [PATCH] [PR #9114/bafb8aca backport][stable-10] redfish_utils: remove undocumented default applytime (#9120) redfish_utils: remove undocumented default applytime (#9114) * redfish_utils: remove undocumented default applytime The `@Redfish.OperationApplyTime` parameter is optional as per Redfish spec version 1.21.0, paragraph 7.11 [1]. Some systems reject the request rather than ignore it, causing failures that can not be workarounded. Removing this default resolves compatibility issues. [1] https://www.dmtf.org/sites/default/files/standards/documents/DSP0266_1.21.0.html Signed-off-by: Tan Siewert * redfish_utils: fix changelog fragment to bugfix Signed-off-by: Tan Siewert --------- Signed-off-by: Tan Siewert (cherry picked from commit bafb8aca292dfb365a6386cc52e4de40f8e6bfc6) Co-authored-by: Tan Siewert --- .../9114-redfish-utils-update-remove-default-applytime.yml | 2 ++ plugins/module_utils/redfish_utils.py | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 changelogs/fragments/9114-redfish-utils-update-remove-default-applytime.yml diff --git a/changelogs/fragments/9114-redfish-utils-update-remove-default-applytime.yml b/changelogs/fragments/9114-redfish-utils-update-remove-default-applytime.yml new file mode 100644 index 0000000000..672545a0a8 --- /dev/null +++ b/changelogs/fragments/9114-redfish-utils-update-remove-default-applytime.yml @@ -0,0 +1,2 @@ +bugfixes: + - redfish_utils module utils - remove undocumented default applytime (https://github.com/ansible-collections/community.general/pull/9114). diff --git a/plugins/module_utils/redfish_utils.py b/plugins/module_utils/redfish_utils.py index f795eac6cd..9f638c51f4 100644 --- a/plugins/module_utils/redfish_utils.py +++ b/plugins/module_utils/redfish_utils.py @@ -1958,7 +1958,7 @@ class RedfishUtils(object): update_uri = data['MultipartHttpPushUri'] # Assemble the JSON payload portion of the request - payload = {"@Redfish.OperationApplyTime": "Immediate"} + payload = {} if targets: payload["Targets"] = targets if apply_time: