ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-05-04 00:01:30 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

tempfile.mkstemp() actually returns a file descriptor which should be closed. (#35263)

Browse source
This commit is contained in:
Felix Fontein 2018-01-24 13:06:10 +01:00 • committed by John R Barker
parent 798cd41b34
commit 0f17d74f0f
1 changed files with 7 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

10
lib/ansible/modules/web_infrastructure/letsencrypt.py
View file

@ -315,12 +315,16 @@ def write_file(module, dest, content):
has changed. has changed.
''' '''
changed = False changed = False
# create a tempfile with some test content # create a tempfile
_, tmpsrc = tempfile.mkstemp() fd, tmpsrc = tempfile.mkstemp(text=False)
f = open(tmpsrc, 'wb') f = os.fdopen(fd, 'wb')
try: try:
f.write(content) f.write(content)
except Exception as err: except Exception as err:
try:
f.close()
except:
pass
os.remove(tmpsrc) os.remove(tmpsrc)
module.fail_json(msg="failed to create temporary content file: %s" % to_native(err), exception=traceback.format_exc()) module.fail_json(msg="failed to create temporary content file: %s" % to_native(err), exception=traceback.format_exc())
f.close() f.close()