ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-04-24 19:31:26 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

fixed disappearing groups on OSX user module

Browse source 
Ensure that we don't try to modify the groups collection if groups are not specified
This commit is contained in:
nitzmahone 2015-12-08 16:16:23 -05:00 • committed by Matt Clay
parent 5c05016d1e
commit 0d0b78dd1e
1 changed files with 10 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

18
lib/ansible/modules/system/user.py
View file

@ -1673,9 +1673,10 @@ class DarwinUser(User):
self._update_system_user() self._update_system_user()
# here we don't care about change status since it is a creation, # here we don't care about change status since it is a creation,
# thus changed is always true. # thus changed is always true.
(rc, _out, _err, changed) = self._modify_group() if self.groups:
out += _out (rc, _out, _err, changed) = self._modify_group()
err += _err out += _out
err += _err
return (rc, err, out) return (rc, err, out)
def modify_user(self): def modify_user(self):
@ -1707,12 +1708,13 @@ class DarwinUser(User):
err += _err err += _err
changed = rc changed = rc
(rc, _out, _err, _changed) = self._modify_group() if self.groups:
out += _out (rc, _out, _err, _changed) = self._modify_group()
err += _err out += _out
err += _err
if _changed is True: if _changed is True:
changed = rc changed = rc
rc = self._update_system_user() rc = self._update_system_user()
if rc == 0: if rc == 0: