Tidy up validations + bug fixes + deprecations (#1830) (#1841)

* fixed validation-modules for plugins/modules/database/misc/elasticsearch_plugin.py

* fixed validation-modules for plugins/modules/database/misc/kibana_plugin.py

* fixed validation-modules for plugins/modules/database/misc/riak.py

* fixed validation-modules for plugins/modules/database/vertica/vertica_info.py

* fixed validation-modules for plugins/modules/database/vertica/vertica_role.py

* fixed validation-modules for plugins/modules/database/vertica/vertica_schema.py

* fixed validation-modules for plugins/modules/database/vertica/vertica_user.py

* fixed validation-modules for plugins/modules/storage/ibm/ibm_sa_domain.py

* fixed validation-modules for plugins/modules/storage/ibm/ibm_sa_host_ports.py

* fixed validation-modules for plugins/modules/storage/ibm/ibm_sa_host.py

* fixed validation-modules for plugins/modules/storage/ibm/ibm_sa_pool.py

* fixed validation-modules for plugins/modules/storage/ibm/ibm_sa_vol.py

* fixed validation-modules for plugins/modules/storage/ibm/ibm_sa_vol_map.py

* fixed validation-modules for plugins/modules/storage/ibm/ibm_sa_host_ports.py

* fixed validation-modules for plugins/modules/system/runit.py

* fixed validation-modules for plugins/modules/source_control/bzr.py

* fixed validation-modules for plugins/modules/source_control/hg.py

* fixed validation-modules for plugins/modules/storage/emc/emc_vnx_sg_member.py

* fixed validation-modules for plugins/modules/identity/opendj/opendj_backendprop.py

* fixed validation-modules for plugins/modules/files/iso_extract.py

* fixed validation-modules for plugins/modules/monitoring/logstash_plugin.py

* fixed validation-modules for plugins/modules/database/aerospike/aerospike_migrations.py

* Tidy up a number of sanity checks for some modules

* added changelog fragment

* Some parameters in vertica_* had their aliases documented as the name, and sometimes vice-versa as well

* Adjustments per PR

* Rolled back sanity ignores for runit

* Update changelogs/fragments/1830-valmod_docmissingtype_batch1.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 3778eac1ba)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
This commit is contained in:
patchback[bot] 2021-02-16 09:10:13 +00:00 committed by GitHub
commit 0d0884b069
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
26 changed files with 164 additions and 152 deletions

View file

@ -146,32 +146,11 @@ plugins/modules/clustering/consul/consul_session.py validate-modules:parameter-s
plugins/modules/clustering/etcd3.py validate-modules:parameter-type-not-in-doc
plugins/modules/clustering/znode.py validate-modules:doc-missing-type
plugins/modules/clustering/znode.py validate-modules:parameter-type-not-in-doc
plugins/modules/database/aerospike/aerospike_migrations.py yamllint:unparsable-with-libyaml
plugins/modules/database/misc/elasticsearch_plugin.py validate-modules:doc-missing-type
plugins/modules/database/misc/elasticsearch_plugin.py validate-modules:invalid-ansiblemodule-schema
plugins/modules/database/misc/elasticsearch_plugin.py validate-modules:parameter-type-not-in-doc
plugins/modules/database/misc/kibana_plugin.py validate-modules:doc-missing-type
plugins/modules/database/misc/kibana_plugin.py validate-modules:invalid-ansiblemodule-schema
plugins/modules/database/misc/kibana_plugin.py validate-modules:parameter-type-not-in-doc
plugins/modules/database/misc/riak.py validate-modules:doc-default-does-not-match-spec
plugins/modules/database/misc/riak.py validate-modules:doc-missing-type
plugins/modules/database/misc/riak.py validate-modules:parameter-type-not-in-doc
plugins/modules/database/vertica/vertica_info.py validate-modules:doc-missing-type
plugins/modules/database/vertica/vertica_role.py validate-modules:doc-missing-type
plugins/modules/database/vertica/vertica_role.py validate-modules:undocumented-parameter
plugins/modules/database/vertica/vertica_schema.py validate-modules:doc-missing-type
plugins/modules/database/vertica/vertica_schema.py validate-modules:undocumented-parameter
plugins/modules/database/vertica/vertica_user.py validate-modules:doc-missing-type
plugins/modules/database/vertica/vertica_user.py validate-modules:undocumented-parameter
plugins/modules/files/iso_extract.py validate-modules:doc-default-does-not-match-spec
plugins/modules/identity/opendj/opendj_backendprop.py validate-modules:doc-missing-type
plugins/modules/identity/opendj/opendj_backendprop.py validate-modules:parameter-type-not-in-doc
plugins/modules/monitoring/bigpanda.py validate-modules:invalid-argument-name
plugins/modules/monitoring/datadog/datadog_event.py validate-modules:parameter-list-no-elements
plugins/modules/monitoring/datadog/datadog_monitor.py validate-modules:invalid-argument-name
plugins/modules/monitoring/datadog/datadog_monitor.py validate-modules:parameter-list-no-elements
plugins/modules/monitoring/icinga2_host.py validate-modules:undocumented-parameter
plugins/modules/monitoring/logstash_plugin.py validate-modules:invalid-ansiblemodule-schema
plugins/modules/monitoring/sensu/sensu_check.py validate-modules:parameter-list-no-elements
plugins/modules/monitoring/sensu/sensu_client.py validate-modules:parameter-list-no-elements
plugins/modules/monitoring/sensu/sensu_handler.py validate-modules:parameter-list-no-elements
@ -258,7 +237,6 @@ plugins/modules/remote_management/stacki/stacki_host.py validate-modules:doc-def
plugins/modules/remote_management/stacki/stacki_host.py validate-modules:no-default-for-required-parameter
plugins/modules/remote_management/stacki/stacki_host.py validate-modules:parameter-type-not-in-doc
plugins/modules/remote_management/stacki/stacki_host.py validate-modules:undocumented-parameter
plugins/modules/source_control/bzr.py validate-modules:parameter-type-not-in-doc
plugins/modules/source_control/git_config.py validate-modules:doc-missing-type
plugins/modules/source_control/git_config.py validate-modules:parameter-type-not-in-doc
plugins/modules/source_control/github/github_deploy_key.py validate-modules:doc-missing-type
@ -271,19 +249,10 @@ plugins/modules/source_control/github/github_release.py validate-modules:doc-mis
plugins/modules/source_control/github/github_release.py validate-modules:parameter-type-not-in-doc
plugins/modules/source_control/github/github_webhook.py validate-modules:parameter-type-not-in-doc
plugins/modules/source_control/github/github_webhook_info.py validate-modules:parameter-type-not-in-doc
plugins/modules/source_control/hg.py validate-modules:parameter-type-not-in-doc
plugins/modules/storage/emc/emc_vnx_sg_member.py validate-modules:doc-missing-type
plugins/modules/storage/emc/emc_vnx_sg_member.py validate-modules:parameter-type-not-in-doc
plugins/modules/storage/glusterfs/gluster_heal_info.py validate-modules:parameter-type-not-in-doc
plugins/modules/storage/glusterfs/gluster_peer.py validate-modules:parameter-list-no-elements
plugins/modules/storage/glusterfs/gluster_volume.py validate-modules:parameter-list-no-elements
plugins/modules/storage/glusterfs/gluster_volume.py validate-modules:parameter-type-not-in-doc
plugins/modules/storage/ibm/ibm_sa_domain.py validate-modules:doc-missing-type
plugins/modules/storage/ibm/ibm_sa_host.py validate-modules:doc-missing-type
plugins/modules/storage/ibm/ibm_sa_host_ports.py validate-modules:doc-missing-type
plugins/modules/storage/ibm/ibm_sa_pool.py validate-modules:doc-missing-type
plugins/modules/storage/ibm/ibm_sa_vol.py validate-modules:doc-missing-type
plugins/modules/storage/ibm/ibm_sa_vol_map.py validate-modules:doc-missing-type
plugins/modules/storage/netapp/na_ontap_gather_facts.py validate-modules:parameter-state-invalid-choice
plugins/modules/storage/purestorage/purefa_facts.py validate-modules:doc-required-mismatch
plugins/modules/storage/purestorage/purefa_facts.py validate-modules:parameter-list-no-elements

View file

@ -145,32 +145,11 @@ plugins/modules/clustering/consul/consul_session.py validate-modules:parameter-s
plugins/modules/clustering/etcd3.py validate-modules:parameter-type-not-in-doc
plugins/modules/clustering/znode.py validate-modules:doc-missing-type
plugins/modules/clustering/znode.py validate-modules:parameter-type-not-in-doc
plugins/modules/database/aerospike/aerospike_migrations.py yamllint:unparsable-with-libyaml
plugins/modules/database/misc/elasticsearch_plugin.py validate-modules:doc-missing-type
plugins/modules/database/misc/elasticsearch_plugin.py validate-modules:invalid-ansiblemodule-schema
plugins/modules/database/misc/elasticsearch_plugin.py validate-modules:parameter-type-not-in-doc
plugins/modules/database/misc/kibana_plugin.py validate-modules:doc-missing-type
plugins/modules/database/misc/kibana_plugin.py validate-modules:invalid-ansiblemodule-schema
plugins/modules/database/misc/kibana_plugin.py validate-modules:parameter-type-not-in-doc
plugins/modules/database/misc/riak.py validate-modules:doc-default-does-not-match-spec
plugins/modules/database/misc/riak.py validate-modules:doc-missing-type
plugins/modules/database/misc/riak.py validate-modules:parameter-type-not-in-doc
plugins/modules/database/vertica/vertica_info.py validate-modules:doc-missing-type
plugins/modules/database/vertica/vertica_role.py validate-modules:doc-missing-type
plugins/modules/database/vertica/vertica_role.py validate-modules:undocumented-parameter
plugins/modules/database/vertica/vertica_schema.py validate-modules:doc-missing-type
plugins/modules/database/vertica/vertica_schema.py validate-modules:undocumented-parameter
plugins/modules/database/vertica/vertica_user.py validate-modules:doc-missing-type
plugins/modules/database/vertica/vertica_user.py validate-modules:undocumented-parameter
plugins/modules/files/iso_extract.py validate-modules:doc-default-does-not-match-spec
plugins/modules/identity/opendj/opendj_backendprop.py validate-modules:doc-missing-type
plugins/modules/identity/opendj/opendj_backendprop.py validate-modules:parameter-type-not-in-doc
plugins/modules/monitoring/bigpanda.py validate-modules:invalid-argument-name
plugins/modules/monitoring/datadog/datadog_event.py validate-modules:parameter-list-no-elements
plugins/modules/monitoring/datadog/datadog_monitor.py validate-modules:invalid-argument-name
plugins/modules/monitoring/datadog/datadog_monitor.py validate-modules:parameter-list-no-elements
plugins/modules/monitoring/icinga2_host.py validate-modules:undocumented-parameter
plugins/modules/monitoring/logstash_plugin.py validate-modules:invalid-ansiblemodule-schema
plugins/modules/monitoring/sensu/sensu_check.py validate-modules:parameter-list-no-elements
plugins/modules/monitoring/sensu/sensu_client.py validate-modules:parameter-list-no-elements
plugins/modules/monitoring/sensu/sensu_handler.py validate-modules:parameter-list-no-elements
@ -257,7 +236,6 @@ plugins/modules/remote_management/stacki/stacki_host.py validate-modules:doc-def
plugins/modules/remote_management/stacki/stacki_host.py validate-modules:no-default-for-required-parameter
plugins/modules/remote_management/stacki/stacki_host.py validate-modules:parameter-type-not-in-doc
plugins/modules/remote_management/stacki/stacki_host.py validate-modules:undocumented-parameter
plugins/modules/source_control/bzr.py validate-modules:parameter-type-not-in-doc
plugins/modules/source_control/git_config.py validate-modules:doc-missing-type
plugins/modules/source_control/git_config.py validate-modules:parameter-type-not-in-doc
plugins/modules/source_control/github/github_deploy_key.py validate-modules:doc-missing-type
@ -270,19 +248,10 @@ plugins/modules/source_control/github/github_release.py validate-modules:doc-mis
plugins/modules/source_control/github/github_release.py validate-modules:parameter-type-not-in-doc
plugins/modules/source_control/github/github_webhook.py validate-modules:parameter-type-not-in-doc
plugins/modules/source_control/github/github_webhook_info.py validate-modules:parameter-type-not-in-doc
plugins/modules/source_control/hg.py validate-modules:parameter-type-not-in-doc
plugins/modules/storage/emc/emc_vnx_sg_member.py validate-modules:doc-missing-type
plugins/modules/storage/emc/emc_vnx_sg_member.py validate-modules:parameter-type-not-in-doc
plugins/modules/storage/glusterfs/gluster_heal_info.py validate-modules:parameter-type-not-in-doc
plugins/modules/storage/glusterfs/gluster_peer.py validate-modules:parameter-list-no-elements
plugins/modules/storage/glusterfs/gluster_volume.py validate-modules:parameter-list-no-elements
plugins/modules/storage/glusterfs/gluster_volume.py validate-modules:parameter-type-not-in-doc
plugins/modules/storage/ibm/ibm_sa_domain.py validate-modules:doc-missing-type
plugins/modules/storage/ibm/ibm_sa_host.py validate-modules:doc-missing-type
plugins/modules/storage/ibm/ibm_sa_host_ports.py validate-modules:doc-missing-type
plugins/modules/storage/ibm/ibm_sa_pool.py validate-modules:doc-missing-type
plugins/modules/storage/ibm/ibm_sa_vol.py validate-modules:doc-missing-type
plugins/modules/storage/ibm/ibm_sa_vol_map.py validate-modules:doc-missing-type
plugins/modules/storage/netapp/na_ontap_gather_facts.py validate-modules:parameter-state-invalid-choice
plugins/modules/storage/purestorage/purefa_facts.py validate-modules:doc-required-mismatch
plugins/modules/storage/purestorage/purefa_facts.py validate-modules:parameter-list-no-elements

View file

@ -157,24 +157,6 @@ plugins/modules/clustering/consul/consul_kv.py validate-modules:parameter-type-n
plugins/modules/clustering/etcd3.py validate-modules:parameter-type-not-in-doc
plugins/modules/clustering/znode.py validate-modules:doc-missing-type
plugins/modules/clustering/znode.py validate-modules:parameter-type-not-in-doc
plugins/modules/database/misc/elasticsearch_plugin.py validate-modules:doc-missing-type
plugins/modules/database/misc/elasticsearch_plugin.py validate-modules:parameter-type-not-in-doc
plugins/modules/database/misc/kibana_plugin.py validate-modules:doc-missing-type
plugins/modules/database/misc/kibana_plugin.py validate-modules:parameter-type-not-in-doc
plugins/modules/database/misc/riak.py validate-modules:doc-default-does-not-match-spec
plugins/modules/database/misc/riak.py validate-modules:doc-missing-type
plugins/modules/database/misc/riak.py validate-modules:parameter-type-not-in-doc
plugins/modules/database/vertica/vertica_configuration.py validate-modules:doc-missing-type
plugins/modules/database/vertica/vertica_info.py validate-modules:doc-missing-type
plugins/modules/database/vertica/vertica_role.py validate-modules:doc-missing-type
plugins/modules/database/vertica/vertica_role.py validate-modules:undocumented-parameter
plugins/modules/database/vertica/vertica_schema.py validate-modules:doc-missing-type
plugins/modules/database/vertica/vertica_schema.py validate-modules:undocumented-parameter
plugins/modules/database/vertica/vertica_user.py validate-modules:doc-missing-type
plugins/modules/database/vertica/vertica_user.py validate-modules:undocumented-parameter
plugins/modules/files/iso_extract.py validate-modules:doc-default-does-not-match-spec
plugins/modules/identity/opendj/opendj_backendprop.py validate-modules:doc-missing-type
plugins/modules/identity/opendj/opendj_backendprop.py validate-modules:parameter-type-not-in-doc
plugins/modules/monitoring/icinga2_host.py validate-modules:undocumented-parameter
plugins/modules/net_tools/ldap/ldap_attr.py validate-modules:deprecation-mismatch
plugins/modules/net_tools/ldap/ldap_attr.py validate-modules:invalid-documentation
@ -244,7 +226,6 @@ plugins/modules/remote_management/stacki/stacki_host.py validate-modules:doc-def
plugins/modules/remote_management/stacki/stacki_host.py validate-modules:no-default-for-required-parameter
plugins/modules/remote_management/stacki/stacki_host.py validate-modules:parameter-type-not-in-doc
plugins/modules/remote_management/stacki/stacki_host.py validate-modules:undocumented-parameter
plugins/modules/source_control/bzr.py validate-modules:parameter-type-not-in-doc
plugins/modules/source_control/git_config.py validate-modules:doc-missing-type
plugins/modules/source_control/git_config.py validate-modules:parameter-type-not-in-doc
plugins/modules/source_control/github/github_deploy_key.py validate-modules:doc-missing-type
@ -257,9 +238,6 @@ plugins/modules/source_control/github/github_release.py validate-modules:doc-mis
plugins/modules/source_control/github/github_release.py validate-modules:parameter-type-not-in-doc
plugins/modules/source_control/github/github_webhook.py validate-modules:parameter-type-not-in-doc
plugins/modules/source_control/github/github_webhook_info.py validate-modules:parameter-type-not-in-doc
plugins/modules/source_control/hg.py validate-modules:parameter-type-not-in-doc
plugins/modules/storage/emc/emc_vnx_sg_member.py validate-modules:doc-missing-type
plugins/modules/storage/emc/emc_vnx_sg_member.py validate-modules:parameter-type-not-in-doc
plugins/modules/storage/glusterfs/gluster_heal_info.py validate-modules:deprecation-mismatch
plugins/modules/storage/glusterfs/gluster_heal_info.py validate-modules:invalid-documentation
plugins/modules/storage/glusterfs/gluster_heal_info.py validate-modules:parameter-type-not-in-doc
@ -268,12 +246,6 @@ plugins/modules/storage/glusterfs/gluster_peer.py validate-modules:invalid-docum
plugins/modules/storage/glusterfs/gluster_volume.py validate-modules:deprecation-mismatch
plugins/modules/storage/glusterfs/gluster_volume.py validate-modules:invalid-documentation
plugins/modules/storage/glusterfs/gluster_volume.py validate-modules:parameter-type-not-in-doc
plugins/modules/storage/ibm/ibm_sa_domain.py validate-modules:doc-missing-type
plugins/modules/storage/ibm/ibm_sa_host.py validate-modules:doc-missing-type
plugins/modules/storage/ibm/ibm_sa_host_ports.py validate-modules:doc-missing-type
plugins/modules/storage/ibm/ibm_sa_pool.py validate-modules:doc-missing-type
plugins/modules/storage/ibm/ibm_sa_vol.py validate-modules:doc-missing-type
plugins/modules/storage/ibm/ibm_sa_vol_map.py validate-modules:doc-missing-type
plugins/modules/storage/netapp/na_ontap_gather_facts.py validate-modules:deprecation-mismatch
plugins/modules/storage/netapp/na_ontap_gather_facts.py validate-modules:invalid-documentation
plugins/modules/storage/purestorage/purefa_facts.py validate-modules:deprecation-mismatch