From 0ccb961ff7b918e6d59feccbb612bebd211f3497 Mon Sep 17 00:00:00 2001 From: "patchback[bot]" <45432694+patchback[bot]@users.noreply.github.com> Date: Sun, 9 Mar 2025 08:56:49 +0100 Subject: [PATCH] [PR #9853/4727fb77 backport][stable-9] cmd_runner tests: fix reliance on unspecified behavior (#9856) cmd_runner tests: fix reliance on unspecified behavior (#9853) Fix reliance on unspecified behavior. (cherry picked from commit 4727fb77b367a3c79dd549cbfd0803ad0b64098b) Co-authored-by: Felix Fontein --- .../targets/cmd_runner/library/cmd_echo.py | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/tests/integration/targets/cmd_runner/library/cmd_echo.py b/tests/integration/targets/cmd_runner/library/cmd_echo.py index ec0beb98e7..1dda75ec93 100644 --- a/tests/integration/targets/cmd_runner/library/cmd_echo.py +++ b/tests/integration/targets/cmd_runner/library/cmd_echo.py @@ -7,6 +7,8 @@ from __future__ import absolute_import, division, print_function __metaclass__ = type +import traceback + DOCUMENTATION = "" @@ -43,15 +45,18 @@ def main(): arg_formats[arg] = func(*args) - runner = CmdRunner(module, [module.params["cmd"], '--'], arg_formats=arg_formats, path_prefix=module.params["path_prefix"]) + try: + runner = CmdRunner(module, [module.params["cmd"], '--'], arg_formats=arg_formats, path_prefix=module.params["path_prefix"]) - with runner.context(p['arg_order'], check_mode_skip=p['check_mode_skip']) as ctx: - result = ctx.run(**p['arg_values']) - info = ctx.run_info - check = "check" - rc, out, err = result if result is not None else (None, None, None) + with runner.context(p['arg_order'], check_mode_skip=p['check_mode_skip']) as ctx: + result = ctx.run(**p['arg_values']) + info = ctx.run_info + check = "check" + rc, out, err = result if result is not None else (None, None, None) - module.exit_json(rc=rc, out=out, err=err, info=info) + module.exit_json(rc=rc, out=out, err=err, info=info) + except Exception as exc: + module.fail_json(rc=1, module_stderr=traceback.format_exc(), msg="Module crashed with exception") if __name__ == '__main__':