nxos_vlan tweaks (#23194)

* Remove commented code

Remove a lot of unnecessary output

* Tests

* Sort vlan ids _after_ running set operations, so order is not lost

test/sanity/pep8/legacy-files.txt

@@ -601,7 +601,6 @@ lib/ansible/modules/network/nxos/nxos_system.py
 lib/ansible/modules/network/nxos/nxos_udld.py
 lib/ansible/modules/network/nxos/nxos_udld_interface.py
 lib/ansible/modules/network/nxos/nxos_user.py
-lib/ansible/modules/network/nxos/nxos_vlan.py
 lib/ansible/modules/network/nxos/nxos_vpc.py
 lib/ansible/modules/network/nxos/nxos_vpc_interface.py
 lib/ansible/modules/network/nxos/nxos_vrf.py

test/units/modules/network/nxos/fixtures/nxos_vlan/show_vlan.txt

@@ -0,0 +1,18 @@
+{
+  "TABLE_vlanbrief": {
+    "ROW_vlanbrief": {
+      "vlanshowbr-vlanid": 16777216, 
+      "vlanshowbr-vlanid-utf": 1, 
+      "vlanshowbr-vlanname": "default", 
+      "vlanshowbr-vlanstate": "active", 
+      "vlanshowbr-shutstate": "noshutdown"
+    }
+  }, 
+  "TABLE_mtuinfo": {
+    "ROW_mtuinfo": {
+      "vlanshowinfo-vlanid": 1, 
+      "vlanshowinfo-media-type": "enet", 
+      "vlanshowinfo-vlanmode": "ce-vlan"
+    }
+  }
+}

test/units/modules/network/nxos/fixtures/nxos_vlan/show_vlan_id_1.txt

@@ -0,0 +1,20 @@
+{
+  "TABLE_vlanbriefid": {
+    "ROW_vlanbriefid": {
+      "vlanshowbr-vlanid": 16777216, 
+      "vlanshowbr-vlanid-utf": 1, 
+      "vlanshowbr-vlanname": "default", 
+      "vlanshowbr-vlanstate": "active", 
+      "vlanshowbr-shutstate": "noshutdown"
+    }
+  }, 
+  "TABLE_mtuinfoid": {
+    "ROW_mtuinfoid": {
+      "vlanshowinfo-vlanid": 1, 
+      "vlanshowinfo-media-type": "enet", 
+      "vlanshowinfo-vlanmode": "ce-vlan"
+    }
+  }, 
+  "vlanshowrspan-vlantype": "notrspan", 
+  "is-vtp-manageable": "enabled"
+}

test/units/modules/network/nxos/test_nxos_vlan.py

@@ -0,0 +1,99 @@
+# (c) 2016 Red Hat Inc.
+#
+# This file is part of Ansible
+#
+# Ansible is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# Ansible is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
+
+# Make coding more python3-ish
+from __future__ import (absolute_import, division, print_function)
+__metaclass__ = type
+
+import json
+
+from ansible.compat.tests.mock import patch
+from ansible.modules.network.nxos import nxos_vlan
+from .nxos_module import TestNxosModule, load_fixture, set_module_args
+
+
+class TestNxosVlanModule(TestNxosModule):
+
+    module = nxos_vlan
+
+    def setUp(self):
+        self.mock_run_commands = patch('ansible.modules.network.nxos.nxos_vlan.run_commands')
+        self.run_commands = self.mock_run_commands.start()
+
+        self.mock_load_config = patch('ansible.modules.network.nxos.nxos_vlan.load_config')
+        self.load_config = self.mock_load_config.start()
+
+        self.mock_get_config = patch('ansible.modules.network.nxos.nxos_vlan.get_config')
+        self.get_config = self.mock_get_config.start()
+
+    def tearDown(self):
+        self.mock_run_commands.stop()
+        self.mock_load_config.stop()
+
+    def load_fixtures(self, commands=None):
+        def load_from_file(*args, **kwargs):
+            module, commands = args
+            output = list()
+
+            for item in commands:
+                try:
+                    obj = json.loads(item)
+                    command = obj['command']
+                except ValueError:
+                    command = item
+                filename = str(command).split(' | ')[0].replace(' ', '_')
+                filename = 'nxos_vlan/%s.txt' % filename
+                output.append(load_fixture(filename))
+            return output
+
+        self.run_commands.side_effect = load_from_file
+        self.load_config.return_value = None
+
+    def test_nxos_vlan_range(self):
+        set_module_args(dict(vlan_range='6-10'))
+        result = self.execute_module(changed=True)
+        self.assertEqual(result['commands'], ['vlan 6', 'vlan 7', 'vlan 8', 'vlan 9', 'vlan 10'])
+
+    def test_nxos_vlan_range_absent(self):
+        set_module_args(dict(vlan_range='1-5', state='absent'))
+        result = self.execute_module(changed=True)
+        self.assertEqual(result['commands'], ['no vlan 1'])
+
+    def test_nxos_vlan_id(self):
+        set_module_args(dict(vlan_id='15', state='present'))
+        result = self.execute_module(changed=True)
+        self.assertEqual(result['commands'], ['vlan 15', 'exit'])
+
+    def test_nxos_vlan_id_absent(self):
+        set_module_args(dict(vlan_id='1', state='absent'))
+        result = self.execute_module(changed=True)
+        self.assertEqual(result['commands'], ['no vlan 1'])
+
+    def test_nxos_vlan_named_vlan(self):
+        set_module_args(dict(vlan_id='15', name='WEB'))
+        result = self.execute_module(changed=True)
+        self.assertEqual(result['commands'], ['vlan 15', 'name WEB', 'exit'])
+
+    def test_nxos_vlan_shut_down(self):
+        set_module_args(dict(vlan_id='1', admin_state='down'))
+        result = self.execute_module(changed=True)
+        self.assertEqual(result['commands'], ['vlan 1', 'shutdown', 'exit'])
+
+    def test_nxos_vlan_no_change(self):
+        set_module_args(dict(vlan_id='1', name='default', vlan_state='active', admin_state='up'))
+        result = self.execute_module(changed=False)
+        self.assertEqual(result['commands'], [])