Tidy up validations + bug fixes + deprecations (#1830) (#1846)

* fixed validation-modules for plugins/modules/database/misc/elasticsearch_plugin.py

* fixed validation-modules for plugins/modules/database/misc/kibana_plugin.py

* fixed validation-modules for plugins/modules/database/misc/riak.py

* fixed validation-modules for plugins/modules/database/vertica/vertica_info.py

* fixed validation-modules for plugins/modules/database/vertica/vertica_role.py

* fixed validation-modules for plugins/modules/database/vertica/vertica_schema.py

* fixed validation-modules for plugins/modules/database/vertica/vertica_user.py

* fixed validation-modules for plugins/modules/storage/ibm/ibm_sa_domain.py

* fixed validation-modules for plugins/modules/storage/ibm/ibm_sa_host_ports.py

* fixed validation-modules for plugins/modules/storage/ibm/ibm_sa_host.py

* fixed validation-modules for plugins/modules/storage/ibm/ibm_sa_pool.py

* fixed validation-modules for plugins/modules/storage/ibm/ibm_sa_vol.py

* fixed validation-modules for plugins/modules/storage/ibm/ibm_sa_vol_map.py

* fixed validation-modules for plugins/modules/storage/ibm/ibm_sa_host_ports.py

* fixed validation-modules for plugins/modules/system/runit.py

* fixed validation-modules for plugins/modules/source_control/bzr.py

* fixed validation-modules for plugins/modules/source_control/hg.py

* fixed validation-modules for plugins/modules/storage/emc/emc_vnx_sg_member.py

* fixed validation-modules for plugins/modules/identity/opendj/opendj_backendprop.py

* fixed validation-modules for plugins/modules/files/iso_extract.py

* fixed validation-modules for plugins/modules/monitoring/logstash_plugin.py

* fixed validation-modules for plugins/modules/database/aerospike/aerospike_migrations.py

* Tidy up a number of sanity checks for some modules

* added changelog fragment

* Some parameters in vertica_* had their aliases documented as the name, and sometimes vice-versa as well

* Adjustments per PR

* Rolled back sanity ignores for runit

* Update changelogs/fragments/1830-valmod_docmissingtype_batch1.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 3778eac1ba)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
This commit is contained in:
Felix Fontein 2021-02-17 07:16:16 +01:00 committed by GitHub
commit 0aaa5e3d91
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
26 changed files with 164 additions and 152 deletions

View file

@ -199,37 +199,16 @@ plugins/modules/clustering/consul/consul_session.py validate-modules:parameter-s
plugins/modules/clustering/etcd3.py validate-modules:parameter-type-not-in-doc
plugins/modules/clustering/znode.py validate-modules:doc-missing-type
plugins/modules/clustering/znode.py validate-modules:parameter-type-not-in-doc
plugins/modules/database/aerospike/aerospike_migrations.py yamllint:unparsable-with-libyaml
plugins/modules/database/misc/elasticsearch_plugin.py validate-modules:doc-missing-type
plugins/modules/database/misc/elasticsearch_plugin.py validate-modules:invalid-ansiblemodule-schema
plugins/modules/database/misc/elasticsearch_plugin.py validate-modules:parameter-type-not-in-doc
plugins/modules/database/misc/kibana_plugin.py validate-modules:doc-missing-type
plugins/modules/database/misc/kibana_plugin.py validate-modules:invalid-ansiblemodule-schema
plugins/modules/database/misc/kibana_plugin.py validate-modules:parameter-type-not-in-doc
plugins/modules/database/misc/riak.py validate-modules:doc-default-does-not-match-spec
plugins/modules/database/misc/riak.py validate-modules:doc-missing-type
plugins/modules/database/misc/riak.py validate-modules:parameter-type-not-in-doc
plugins/modules/database/postgresql/postgresql_db.py use-argspec-type-path
plugins/modules/database/postgresql/postgresql_db.py validate-modules:use-run-command-not-popen
plugins/modules/database/postgresql/postgresql_privs.py validate-modules:parameter-documented-multiple-times
plugins/modules/database/postgresql/postgresql_tablespace.py validate-modules:mutually_exclusive-unknown
plugins/modules/database/postgresql/postgresql_user.py validate-modules:doc-choices-do-not-match-spec
plugins/modules/database/vertica/vertica_info.py validate-modules:doc-missing-type
plugins/modules/database/vertica/vertica_role.py validate-modules:doc-missing-type
plugins/modules/database/vertica/vertica_role.py validate-modules:undocumented-parameter
plugins/modules/database/vertica/vertica_schema.py validate-modules:doc-missing-type
plugins/modules/database/vertica/vertica_schema.py validate-modules:undocumented-parameter
plugins/modules/database/vertica/vertica_user.py validate-modules:doc-missing-type
plugins/modules/database/vertica/vertica_user.py validate-modules:undocumented-parameter
plugins/modules/files/iso_extract.py validate-modules:doc-default-does-not-match-spec
plugins/modules/identity/opendj/opendj_backendprop.py validate-modules:doc-missing-type
plugins/modules/identity/opendj/opendj_backendprop.py validate-modules:parameter-type-not-in-doc
plugins/modules/monitoring/bigpanda.py validate-modules:invalid-argument-name
plugins/modules/monitoring/datadog/datadog_event.py validate-modules:parameter-list-no-elements
plugins/modules/monitoring/datadog/datadog_monitor.py validate-modules:invalid-argument-name
plugins/modules/monitoring/datadog/datadog_monitor.py validate-modules:parameter-list-no-elements
plugins/modules/monitoring/icinga2_host.py validate-modules:undocumented-parameter
plugins/modules/monitoring/logstash_plugin.py validate-modules:invalid-ansiblemodule-schema
plugins/modules/monitoring/sensu/sensu_check.py validate-modules:parameter-list-no-elements
plugins/modules/monitoring/sensu/sensu_client.py validate-modules:parameter-list-no-elements
plugins/modules/monitoring/sensu/sensu_handler.py validate-modules:parameter-list-no-elements
@ -405,7 +384,6 @@ plugins/modules/remote_management/stacki/stacki_host.py validate-modules:doc-def
plugins/modules/remote_management/stacki/stacki_host.py validate-modules:no-default-for-required-parameter
plugins/modules/remote_management/stacki/stacki_host.py validate-modules:parameter-type-not-in-doc
plugins/modules/remote_management/stacki/stacki_host.py validate-modules:undocumented-parameter
plugins/modules/source_control/bzr.py validate-modules:parameter-type-not-in-doc
plugins/modules/source_control/git_config.py validate-modules:doc-missing-type
plugins/modules/source_control/git_config.py validate-modules:parameter-type-not-in-doc
plugins/modules/source_control/github/github_deploy_key.py validate-modules:doc-missing-type
@ -419,19 +397,10 @@ plugins/modules/source_control/github/github_release.py validate-modules:doc-mis
plugins/modules/source_control/github/github_release.py validate-modules:parameter-type-not-in-doc
plugins/modules/source_control/github/github_webhook.py validate-modules:parameter-type-not-in-doc
plugins/modules/source_control/github/github_webhook_info.py validate-modules:parameter-type-not-in-doc
plugins/modules/source_control/hg.py validate-modules:parameter-type-not-in-doc
plugins/modules/storage/emc/emc_vnx_sg_member.py validate-modules:doc-missing-type
plugins/modules/storage/emc/emc_vnx_sg_member.py validate-modules:parameter-type-not-in-doc
plugins/modules/storage/glusterfs/gluster_heal_info.py validate-modules:parameter-type-not-in-doc
plugins/modules/storage/glusterfs/gluster_peer.py validate-modules:parameter-list-no-elements
plugins/modules/storage/glusterfs/gluster_volume.py validate-modules:parameter-list-no-elements
plugins/modules/storage/glusterfs/gluster_volume.py validate-modules:parameter-type-not-in-doc
plugins/modules/storage/ibm/ibm_sa_domain.py validate-modules:doc-missing-type
plugins/modules/storage/ibm/ibm_sa_host.py validate-modules:doc-missing-type
plugins/modules/storage/ibm/ibm_sa_host_ports.py validate-modules:doc-missing-type
plugins/modules/storage/ibm/ibm_sa_pool.py validate-modules:doc-missing-type
plugins/modules/storage/ibm/ibm_sa_vol.py validate-modules:doc-missing-type
plugins/modules/storage/ibm/ibm_sa_vol_map.py validate-modules:doc-missing-type
plugins/modules/storage/netapp/na_cdot_aggregate.py validate-modules:doc-missing-type
plugins/modules/storage/netapp/na_cdot_aggregate.py validate-modules:parameter-type-not-in-doc
plugins/modules/storage/netapp/na_cdot_license.py validate-modules:incompatible-default-type

View file

@ -187,37 +187,16 @@ plugins/modules/clustering/consul/consul_session.py validate-modules:parameter-s
plugins/modules/clustering/etcd3.py validate-modules:parameter-type-not-in-doc
plugins/modules/clustering/znode.py validate-modules:doc-missing-type
plugins/modules/clustering/znode.py validate-modules:parameter-type-not-in-doc
plugins/modules/database/aerospike/aerospike_migrations.py yamllint:unparsable-with-libyaml
plugins/modules/database/misc/elasticsearch_plugin.py validate-modules:doc-missing-type
plugins/modules/database/misc/elasticsearch_plugin.py validate-modules:invalid-ansiblemodule-schema
plugins/modules/database/misc/elasticsearch_plugin.py validate-modules:parameter-type-not-in-doc
plugins/modules/database/misc/kibana_plugin.py validate-modules:doc-missing-type
plugins/modules/database/misc/kibana_plugin.py validate-modules:invalid-ansiblemodule-schema
plugins/modules/database/misc/kibana_plugin.py validate-modules:parameter-type-not-in-doc
plugins/modules/database/misc/riak.py validate-modules:doc-default-does-not-match-spec
plugins/modules/database/misc/riak.py validate-modules:doc-missing-type
plugins/modules/database/misc/riak.py validate-modules:parameter-type-not-in-doc
plugins/modules/database/postgresql/postgresql_db.py use-argspec-type-path
plugins/modules/database/postgresql/postgresql_db.py validate-modules:use-run-command-not-popen
plugins/modules/database/postgresql/postgresql_privs.py validate-modules:parameter-documented-multiple-times
plugins/modules/database/postgresql/postgresql_tablespace.py validate-modules:mutually_exclusive-unknown
plugins/modules/database/postgresql/postgresql_user.py validate-modules:doc-choices-do-not-match-spec
plugins/modules/database/vertica/vertica_info.py validate-modules:doc-missing-type
plugins/modules/database/vertica/vertica_role.py validate-modules:doc-missing-type
plugins/modules/database/vertica/vertica_role.py validate-modules:undocumented-parameter
plugins/modules/database/vertica/vertica_schema.py validate-modules:doc-missing-type
plugins/modules/database/vertica/vertica_schema.py validate-modules:undocumented-parameter
plugins/modules/database/vertica/vertica_user.py validate-modules:doc-missing-type
plugins/modules/database/vertica/vertica_user.py validate-modules:undocumented-parameter
plugins/modules/files/iso_extract.py validate-modules:doc-default-does-not-match-spec
plugins/modules/identity/opendj/opendj_backendprop.py validate-modules:doc-missing-type
plugins/modules/identity/opendj/opendj_backendprop.py validate-modules:parameter-type-not-in-doc
plugins/modules/monitoring/bigpanda.py validate-modules:invalid-argument-name
plugins/modules/monitoring/datadog/datadog_event.py validate-modules:parameter-list-no-elements
plugins/modules/monitoring/datadog/datadog_monitor.py validate-modules:invalid-argument-name
plugins/modules/monitoring/datadog/datadog_monitor.py validate-modules:parameter-list-no-elements
plugins/modules/monitoring/icinga2_host.py validate-modules:undocumented-parameter
plugins/modules/monitoring/logstash_plugin.py validate-modules:invalid-ansiblemodule-schema
plugins/modules/monitoring/sensu/sensu_check.py validate-modules:parameter-list-no-elements
plugins/modules/monitoring/sensu/sensu_client.py validate-modules:parameter-list-no-elements
plugins/modules/monitoring/sensu/sensu_handler.py validate-modules:parameter-list-no-elements
@ -393,7 +372,6 @@ plugins/modules/remote_management/stacki/stacki_host.py validate-modules:doc-def
plugins/modules/remote_management/stacki/stacki_host.py validate-modules:no-default-for-required-parameter
plugins/modules/remote_management/stacki/stacki_host.py validate-modules:parameter-type-not-in-doc
plugins/modules/remote_management/stacki/stacki_host.py validate-modules:undocumented-parameter
plugins/modules/source_control/bzr.py validate-modules:parameter-type-not-in-doc
plugins/modules/source_control/git_config.py validate-modules:doc-missing-type
plugins/modules/source_control/git_config.py validate-modules:parameter-type-not-in-doc
plugins/modules/source_control/github/github_deploy_key.py validate-modules:doc-missing-type
@ -407,19 +385,10 @@ plugins/modules/source_control/github/github_release.py validate-modules:doc-mis
plugins/modules/source_control/github/github_release.py validate-modules:parameter-type-not-in-doc
plugins/modules/source_control/github/github_webhook.py validate-modules:parameter-type-not-in-doc
plugins/modules/source_control/github/github_webhook_info.py validate-modules:parameter-type-not-in-doc
plugins/modules/source_control/hg.py validate-modules:parameter-type-not-in-doc
plugins/modules/storage/emc/emc_vnx_sg_member.py validate-modules:doc-missing-type
plugins/modules/storage/emc/emc_vnx_sg_member.py validate-modules:parameter-type-not-in-doc
plugins/modules/storage/glusterfs/gluster_heal_info.py validate-modules:parameter-type-not-in-doc
plugins/modules/storage/glusterfs/gluster_peer.py validate-modules:parameter-list-no-elements
plugins/modules/storage/glusterfs/gluster_volume.py validate-modules:parameter-list-no-elements
plugins/modules/storage/glusterfs/gluster_volume.py validate-modules:parameter-type-not-in-doc
plugins/modules/storage/ibm/ibm_sa_domain.py validate-modules:doc-missing-type
plugins/modules/storage/ibm/ibm_sa_host.py validate-modules:doc-missing-type
plugins/modules/storage/ibm/ibm_sa_host_ports.py validate-modules:doc-missing-type
plugins/modules/storage/ibm/ibm_sa_pool.py validate-modules:doc-missing-type
plugins/modules/storage/ibm/ibm_sa_vol.py validate-modules:doc-missing-type
plugins/modules/storage/ibm/ibm_sa_vol_map.py validate-modules:doc-missing-type
plugins/modules/storage/netapp/na_cdot_aggregate.py validate-modules:doc-missing-type
plugins/modules/storage/netapp/na_cdot_aggregate.py validate-modules:parameter-type-not-in-doc
plugins/modules/storage/netapp/na_cdot_license.py validate-modules:incompatible-default-type

View file

@ -203,13 +203,6 @@ plugins/modules/clustering/consul/consul_kv.py validate-modules:parameter-type-n
plugins/modules/clustering/etcd3.py validate-modules:parameter-type-not-in-doc
plugins/modules/clustering/znode.py validate-modules:doc-missing-type
plugins/modules/clustering/znode.py validate-modules:parameter-type-not-in-doc
plugins/modules/database/misc/elasticsearch_plugin.py validate-modules:doc-missing-type
plugins/modules/database/misc/elasticsearch_plugin.py validate-modules:parameter-type-not-in-doc
plugins/modules/database/misc/kibana_plugin.py validate-modules:doc-missing-type
plugins/modules/database/misc/kibana_plugin.py validate-modules:parameter-type-not-in-doc
plugins/modules/database/misc/riak.py validate-modules:doc-default-does-not-match-spec
plugins/modules/database/misc/riak.py validate-modules:doc-missing-type
plugins/modules/database/misc/riak.py validate-modules:parameter-type-not-in-doc
plugins/modules/database/postgresql/postgresql_db.py use-argspec-type-path
plugins/modules/database/postgresql/postgresql_db.py validate-modules:parameter-type-not-in-doc
plugins/modules/database/postgresql/postgresql_db.py validate-modules:use-run-command-not-popen
@ -217,17 +210,6 @@ plugins/modules/database/postgresql/postgresql_ext.py validate-modules:parameter
plugins/modules/database/postgresql/postgresql_schema.py validate-modules:parameter-type-not-in-doc
plugins/modules/database/postgresql/postgresql_user.py validate-modules:doc-choices-do-not-match-spec
plugins/modules/database/postgresql/postgresql_user.py validate-modules:parameter-type-not-in-doc
plugins/modules/database/vertica/vertica_configuration.py validate-modules:doc-missing-type
plugins/modules/database/vertica/vertica_info.py validate-modules:doc-missing-type
plugins/modules/database/vertica/vertica_role.py validate-modules:doc-missing-type
plugins/modules/database/vertica/vertica_role.py validate-modules:undocumented-parameter
plugins/modules/database/vertica/vertica_schema.py validate-modules:doc-missing-type
plugins/modules/database/vertica/vertica_schema.py validate-modules:undocumented-parameter
plugins/modules/database/vertica/vertica_user.py validate-modules:doc-missing-type
plugins/modules/database/vertica/vertica_user.py validate-modules:undocumented-parameter
plugins/modules/files/iso_extract.py validate-modules:doc-default-does-not-match-spec
plugins/modules/identity/opendj/opendj_backendprop.py validate-modules:doc-missing-type
plugins/modules/identity/opendj/opendj_backendprop.py validate-modules:parameter-type-not-in-doc
plugins/modules/monitoring/icinga2_host.py validate-modules:undocumented-parameter
plugins/modules/net_tools/ldap/ldap_attr.py validate-modules:deprecation-mismatch
plugins/modules/net_tools/ldap/ldap_attr.py validate-modules:invalid-documentation
@ -369,7 +351,6 @@ plugins/modules/remote_management/stacki/stacki_host.py validate-modules:doc-def
plugins/modules/remote_management/stacki/stacki_host.py validate-modules:no-default-for-required-parameter
plugins/modules/remote_management/stacki/stacki_host.py validate-modules:parameter-type-not-in-doc
plugins/modules/remote_management/stacki/stacki_host.py validate-modules:undocumented-parameter
plugins/modules/source_control/bzr.py validate-modules:parameter-type-not-in-doc
plugins/modules/source_control/git_config.py validate-modules:doc-missing-type
plugins/modules/source_control/git_config.py validate-modules:parameter-type-not-in-doc
plugins/modules/source_control/github/github_deploy_key.py validate-modules:doc-missing-type
@ -385,17 +366,8 @@ plugins/modules/source_control/github/github_release.py validate-modules:doc-mis
plugins/modules/source_control/github/github_release.py validate-modules:parameter-type-not-in-doc
plugins/modules/source_control/github/github_webhook.py validate-modules:parameter-type-not-in-doc
plugins/modules/source_control/github/github_webhook_info.py validate-modules:parameter-type-not-in-doc
plugins/modules/source_control/hg.py validate-modules:parameter-type-not-in-doc
plugins/modules/storage/emc/emc_vnx_sg_member.py validate-modules:doc-missing-type
plugins/modules/storage/emc/emc_vnx_sg_member.py validate-modules:parameter-type-not-in-doc
plugins/modules/storage/glusterfs/gluster_heal_info.py validate-modules:parameter-type-not-in-doc
plugins/modules/storage/glusterfs/gluster_volume.py validate-modules:parameter-type-not-in-doc
plugins/modules/storage/ibm/ibm_sa_domain.py validate-modules:doc-missing-type
plugins/modules/storage/ibm/ibm_sa_host.py validate-modules:doc-missing-type
plugins/modules/storage/ibm/ibm_sa_host_ports.py validate-modules:doc-missing-type
plugins/modules/storage/ibm/ibm_sa_pool.py validate-modules:doc-missing-type
plugins/modules/storage/ibm/ibm_sa_vol.py validate-modules:doc-missing-type
plugins/modules/storage/ibm/ibm_sa_vol_map.py validate-modules:doc-missing-type
plugins/modules/storage/netapp/na_cdot_aggregate.py validate-modules:deprecation-mismatch
plugins/modules/storage/netapp/na_cdot_aggregate.py validate-modules:invalid-documentation
plugins/modules/storage/netapp/na_cdot_aggregate.py validate-modules:missing-main-call