ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-22 12:50:22 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

fix win_shell/win_command nonzero RC failure setting (#26443)

Browse source 
* as a result of recent core engine changes to ignore rc, modules are responsible to set `failed` on nonzero RC if they want that behavior
* the `failed` filter currently triggers on nonzero RC, which caused the tests to false-pass
* updated tests to explicitly check both rc and failed keys, as well as using the failed filter.
This commit is contained in:
Matt Davis 2017-07-05 10:05:07 -07:00 • committed by GitHub
commit 08af853ee9
4 changed files with 11 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
test/integration/targets/win_command/tasks/main.yml
View file

@ -120,6 +120,7 @@
assert:
that:
- cmdout|failed
- cmdout.failed == True # check the failure key explicitly, since failed does magic with RC
- cmdout.rc == 254
- name: interleave large writes between stdout/stderr (check for buffer consumption deadlock)