fix win_shell/win_command nonzero RC failure setting (#26443)

* as a result of recent core engine changes to ignore rc, modules are responsible to set `failed` on nonzero RC if they want that behavior
* the `failed` filter currently triggers on nonzero RC, which caused the tests to false-pass
* updated tests to explicitly check both rc and failed keys, as well as using the failed filter.
This commit is contained in:
Matt Davis 2017-07-05 10:05:07 -07:00 committed by GitHub
commit 08af853ee9
4 changed files with 11 additions and 0 deletions

View file

@ -120,6 +120,7 @@
assert:
that:
- cmdout|failed
- cmdout.failed == True # check the failure key explicitly, since failed does magic with RC
- cmdout.rc == 254
- name: interleave large writes between stdout/stderr (check for buffer consumption deadlock)

View file

@ -47,6 +47,7 @@
assert:
that:
- shellout|failed
- shellout.failed == true # check the failure key explicitly, since failed does magic with RC
- shellout|changed
- shellout.cmd == 'bogus_command1234'
- shellout.delta is match('^\d:(\d){2}:(\d){2}.(\d){6}$')
@ -147,6 +148,7 @@
assert:
that:
- shellout|failed
- shellout.failed == True # check the failure key explicitly, since failed does magic with RC
- shellout.rc == 254
- name: run something via cmd that will fail in powershell