ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-22 12:50:22 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

fix win_shell/win_command nonzero RC failure setting (#26443)

Browse source 
* as a result of recent core engine changes to ignore rc, modules are responsible to set `failed` on nonzero RC if they want that behavior
* the `failed` filter currently triggers on nonzero RC, which caused the tests to false-pass
* updated tests to explicitly check both rc and failed keys, as well as using the failed filter.
This commit is contained in:
Matt Davis 2017-07-05 10:05:07 -07:00 • committed by GitHub
commit 08af853ee9
4 changed files with 11 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/ansible/modules/windows/win_command.ps1
View file

@ -159,6 +159,10 @@ $proc.WaitForExit() | Out-Null
$result.rc = $proc.ExitCode
If ($result.rc -ne 0) {
$result.failed = $true
}
$end_datetime = [DateTime]::UtcNow
$result.start = $start_datetime.ToString("yyyy-MM-dd hh:mm:ss.ffffff")

4
lib/ansible/modules/windows/win_shell.ps1
View file

@ -168,6 +168,10 @@ $proc.WaitForExit() | Out-Null
$result.rc = $proc.ExitCode
If ($result.rc -ne 0) {
$result.failed = $true
}
$end_datetime = [DateTime]::UtcNow
$result.start = $start_datetime.ToString("yyyy-MM-dd hh:mm:ss.ffffff")