ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-22 12:50:22 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

ini_file - allows adding empty string as a value (#1972)

Browse source 
* Added integration test and fixed bug

* added changelog fragment

* Update changelogs/fragments/1972-ini_file-empty-str-value.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update tests/integration/targets/ini_file/tasks/main.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
This commit is contained in:
Alexei Znamensky 2021-03-08 18:57:40 +13:00 • committed by GitHub
commit 088743749b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 42 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
plugins/modules/files/ini_file.py
View file

@ -114,9 +114,7 @@ from ansible.module_utils.basic import AnsibleModule
def match_opt(option, line):
option = re.escape(option)
return re.match('( |\t)*%s( |\t)*(=|$)' % option, line) \
or re.match('#( |\t)*%s( |\t)*(=|$)' % option, line) \
or re.match(';( |\t)*%s( |\t)*(=|$)' % option, line)
return re.match('[#;]?( |\t)*%s( |\t)*(=|$)' % option, line)
def match_active_opt(option, line):
@ -251,9 +249,9 @@ def do_ini(module, filename, section=None, option=None, value=None,
if not within_section and state == 'present':
ini_lines.append('[%s]\n' % section)
msg = 'section and option added'
if option and value:
if option and value is not None:
ini_lines.append(assignment_format % (option, value))
elif option and not value and allow_no_value:
elif option and value is None and allow_no_value:
ini_lines.append('%s\n' % option)
else:
msg = 'only section added'
@ -312,7 +310,7 @@ def main():
allow_no_value = module.params['allow_no_value']
create = module.params['create']
if state == 'present' and not allow_no_value and not value:
if state == 'present' and not allow_no_value and value is None:
module.fail_json("Parameter 'value' must not be empty if state=present and allow_no_value=False")
(changed, backup_file, diff, msg) = do_ini(module, path, section, option, value, state, backup, no_extra_spaces, create, allow_no_value)