ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-24 05:40:23 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

feat(pkgin): add support for installation of full versioned package names (#1256) (#1349)

Browse source 
* * pkgin query_package(..) understands now also package name with version (my-package-1.2nb123456). * pkgin query_package(..) will distinct between not-installed and not-found packages. * pkgin install_package(..) fails with proper error if a non-existing package is attempted to be installed.

* fixup ansibot comments

* add changelog fragment

* add example

* use more pythonic condition

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

* remove extra dot between description and link to PR

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

* fix file extension of changelog fragment

* add pkgin unit tests for query_package function

* fix pep8 issues

* use enum Flag instead mix of strings, bools and None as return value

* use IntEnum instead Flag to support Python versions >= 2.6

* fix pep8 and pylint errors

* use regular class instead enum to avoid issues with older Python releases

* fix comment

* remove the combined package state since without an IntFlag or Flag the usage of it would require to use logical operators

Co-authored-by: Erik van Nooijen <eric.vannooijen@tomtom.com>
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
(cherry picked from commit ece0202507)

Co-authored-by: Martin Migasiewicz <616250+martinm82@users.noreply.github.com>
This commit is contained in:
patchback[bot] 2020-11-21 21:41:09 +01:00 • committed by GitHub
commit 07e35f7505
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 175 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

143
tests/unit/plugins/modules/packaging/os/test_pkgin.py Normal file
View file

@ -0,0 +1,143 @@
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
from __future__ import (absolute_import, division, print_function)
__metaclass__ = type
from ansible_collections.community.general.tests.unit.compat import mock
from ansible_collections.community.general.tests.unit.compat import unittest
from ansible_collections.community.general.plugins.modules.packaging.os import pkgin
class TestPkginQueryPackage(unittest.TestCase):
def setUp(self):
pkgin.PKGIN_PATH = ""
@mock.patch('ansible_collections.community.general.plugins.modules.packaging.os.pkgin.AnsibleModule')
def test_package_without_version_is_present(self, mock_module):
# given
package = 'py37-conan'
parseable_flag_not_supported = 1
mock_module.run_command.side_effect = [
(parseable_flag_not_supported, "pkgin 0.11.7 for Darwin-18.6.0 x86_64 (using SQLite 3.27.2)", None),
(0, "%s-1.21.0 = C/C++ package manager" % package, None),
]
# when
command_result = pkgin.query_package(mock_module, package)
# then
self.assertEquals(command_result, pkgin.PackageState.PRESENT)
@mock.patch('ansible_collections.community.general.plugins.modules.packaging.os.pkgin.AnsibleModule')
def test_package_with_version_is_present(self, mock_module):
# given
package = 'py37-conan-1.21.0'
parseable_flag_not_supported = 1
mock_module.run_command.side_effect = [
(parseable_flag_not_supported, "pkgin 0.11.7 for Darwin-18.6.0 x86_64 (using SQLite 3.27.2)", None),
(0, "%s = C/C++ package manager" % package, None),
]
# when
command_result = pkgin.query_package(mock_module, package)
# then
self.assertEquals(command_result, pkgin.PackageState.PRESENT)
@mock.patch('ansible_collections.community.general.plugins.modules.packaging.os.pkgin.AnsibleModule')
def test_package_found_but_not_installed(self, mock_module):
# given
package = 'cmake'
parseable_flag_not_supported = 1
mock_module.run_command.side_effect = [
(parseable_flag_not_supported, "pkgin 0.11.7 for Darwin-18.6.0 x86_64 (using SQLite 3.27.2)", None),
(0, "cmake316-3.16.0nb1 = Cross platform make\ncmake314-3.14.6nb1 = Cross platform make\ncmake-3.14.0 Cross platform make", None),
]
# when
command_result = pkgin.query_package(mock_module, package)
# then
self.assertEquals(command_result, pkgin.PackageState.NOT_INSTALLED)
@mock.patch('ansible_collections.community.general.plugins.modules.packaging.os.pkgin.AnsibleModule')
def test_package_found_outdated(self, mock_module):
# given
package = 'cmake316'
parseable_flag_not_supported = 1
mock_module.run_command.side_effect = [
(parseable_flag_not_supported, "pkgin 0.11.7 for Darwin-18.6.0 x86_64 (using SQLite 3.27.2)", None),
(0, "cmake316-3.16.0nb1 < Cross platform make", None),
]
# when
command_result = pkgin.query_package(mock_module, package)
# then
self.assertEquals(command_result, pkgin.PackageState.OUTDATED)
@mock.patch('ansible_collections.community.general.plugins.modules.packaging.os.pkgin.AnsibleModule')
def test_package_with_version_found_outdated(self, mock_module):
# given
package = 'cmake316-3.16.0nb1'
parseable_flag_not_supported = 1
mock_module.run_command.side_effect = [
(parseable_flag_not_supported, "pkgin 0.11.7 for Darwin-18.6.0 x86_64 (using SQLite 3.27.2)", None),
(0, "cmake316-3.16.0nb1 < Cross platform make", None),
]
# when
command_result = pkgin.query_package(mock_module, package)
# then
self.assertEquals(command_result, pkgin.PackageState.OUTDATED)
@mock.patch('ansible_collections.community.general.plugins.modules.packaging.os.pkgin.AnsibleModule')
def test_package_not_found(self, mock_module):
# given
package = 'cmake320-3.20.0nb1'
parseable_flag_not_supported = 1
mock_module.run_command.side_effect = [
(parseable_flag_not_supported, "pkgin 0.11.7 for Darwin-18.6.0 x86_64 (using SQLite 3.27.2)", None),
(1, None, "No results found for %s" % package),
]
# when
command_result = pkgin.query_package(mock_module, package)
# then
self.assertEquals(command_result, pkgin.PackageState.NOT_FOUND)
@mock.patch('ansible_collections.community.general.plugins.modules.packaging.os.pkgin.AnsibleModule')
def test_with_parseable_flag_supported_package_is_present(self, mock_module):
# given
package = 'py37-conan'
parseable_flag_supported = 0
mock_module.run_command.side_effect = [
(parseable_flag_supported, "pkgin 0.11.7 for Darwin-18.6.0 x86_64 (using SQLite 3.27.2)", None),
(0, "%s-1.21.0;=;C/C++ package manager" % package, None),
]
# when
command_result = pkgin.query_package(mock_module, package)
# then
self.assertEquals(command_result, pkgin.PackageState.PRESENT)
@mock.patch('ansible_collections.community.general.plugins.modules.packaging.os.pkgin.AnsibleModule')
def test_with_parseable_flag_not_supported_package_is_present(self, mock_module):
# given
package = 'py37-conan'
parseable_flag_not_supported = 1
mock_module.run_command.side_effect = [
(parseable_flag_not_supported, "pkgin 0.11.7 for Darwin-18.6.0 x86_64 (using SQLite 3.27.2)", None),
(0, "%s-1.21.0 = C/C++ package manager" % package, None),
]
# when
command_result = pkgin.query_package(mock_module, package)
# then
self.assertEquals(command_result, pkgin.PackageState.PRESENT)