ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-26 06:31:23 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

ovirt_disk: Check if disk is attached to vm (#55767)

Browse source
This commit is contained in:
Ondra Machacek 2019-04-26 11:25:30 +02:00 • committed by ansibot
commit 0679fbc1d9
1 changed files with 30 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

47
lib/ansible/modules/cloud/ovirt/ovirt_disk.py
View file

@ -612,6 +612,23 @@ def searchable_attributes(module):
return dict((k, v) for k, v in attributes.items() if v is not None) return dict((k, v) for k, v in attributes.items() if v is not None)
def get_vm_service(connection, module):
if module.params.get('vm_id') is not None or module.params.get('vm_name') is not None and module.params['state'] != 'absent':
vms_service = connection.system_service().vms_service()
# If `vm_id` isn't specified, find VM by name:
vm_id = module.params['vm_id']
if vm_id is None:
vm_id = get_id_by_name(vms_service, module.params['vm_name'])
if vm_id is None:
module.fail_json(
msg="VM don't exists, please create it first."
)
return vms_service.vm_service(vm_id)
def main(): def main():
argument_spec = ovirt_full_argument_spec( argument_spec = ovirt_full_argument_spec(
state=dict( state=dict(
@ -678,23 +695,31 @@ def main():
service=disks_service, service=disks_service,
) )
force_create = False
vm_service = get_vm_service(connection, module)
if lun: if lun:
disk = _search_by_lun(disks_service, lun.get('id')) disk = _search_by_lun(disks_service, lun.get('id'))
else:
disk = disks_module.search_entity(search_params=searchable_attributes(module))
if vm_service:
# If the VM don't exist in VMs disks, but still it's found it means it was found
# for template with same name as VM, so we should force create the VM disk.
force_create = disk.id not in [a.disk.id for a in vm_service.disk_attachments_service().list()]
ret = None ret = None
# First take care of creating the VM, if needed: # First take care of creating the VM, if needed:
if state in ('present', 'detached', 'attached'): if state in ('present', 'detached', 'attached'):
ret = disks_module.create( ret = disks_module.create(
entity=disk, entity=disk if not force_create else None,
search_params=searchable_attributes(module),
result_state=otypes.DiskStatus.OK if lun is None else None, result_state=otypes.DiskStatus.OK if lun is None else None,
fail_condition=lambda d: d.status == otypes.DiskStatus.ILLEGAL if lun is None else False, fail_condition=lambda d: d.status == otypes.DiskStatus.ILLEGAL if lun is None else False,
force_create=force_create,
) )
is_new_disk = ret['changed'] is_new_disk = ret['changed']
ret['changed'] = ret['changed'] or disks_module.update_storage_domains(ret['id']) ret['changed'] = ret['changed'] or disks_module.update_storage_domains(ret['id'])
# We need to pass ID to the module, so in case we want detach/attach disk # We need to pass ID to the module, so in case we want detach/attach disk
# we have this ID specified to attach/detach method: # we have this ID specified to attach/detach method:
module.params['id'] = ret['id'] if disk is None else disk.id module.params['id'] = ret['id']
# Upload disk image in case it's new disk or force parameter is passed: # Upload disk image in case it's new disk or force parameter is passed:
if module.params['upload_image_path'] and (is_new_disk or module.params['force']): if module.params['upload_image_path'] and (is_new_disk or module.params['force']):
@ -736,20 +761,8 @@ def main():
ret = disks_module.remove() ret = disks_module.remove()
# If VM was passed attach/detach disks to/from the VM: # If VM was passed attach/detach disks to/from the VM:
if module.params.get('vm_id') is not None or module.params.get('vm_name') is not None and state != 'absent': if vm_service:
vms_service = connection.system_service().vms_service() disk_attachments_service = vm_service.disk_attachments_service()
# If `vm_id` isn't specified, find VM by name:
vm_id = module.params['vm_id']
if vm_id is None:
vm_id = getattr(search_by_name(vms_service, module.params['vm_name']), 'id', None)
if vm_id is None:
module.fail_json(
msg="VM don't exists, please create it first."
)
disk_attachments_service = vms_service.vm_service(vm_id).disk_attachments_service()
disk_attachments_module = DiskAttachmentsModule( disk_attachments_module = DiskAttachmentsModule(
connection=connection, connection=connection,
module=module, module=module,