ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-06-28 19:20:22 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Fix ec2 inventory for potentially inconsistent data (#12642)

Browse source
This commit is contained in:
Adam Chainz 2016-05-24 16:00:59 +01:00 • committed by Jonathan Davila
parent 52a0165c77
commit 064ed63843
1 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

12
contrib/inventory/ec2.py
View file

@ -521,8 +521,20 @@ class Ec2Inventory(object):
else: else:
reservations = conn.get_all_instances() reservations = conn.get_all_instances()
# Pull the tags back in a second step
# AWS are on record as saying that the tags fetched in the first `get_all_instances` request are not
# reliable and may be missing, and the only way to guarantee they are there is by calling `get_all_tags`
instance_ids = []
for reservation in reservations:
instance_ids.extend([instance.id for instance in reservation.instances])
tags = conn.get_all_tags(filters={'resource-type': 'instance', 'resource-id': instance_ids})
tags_by_instance_id = defaultdict(dict)
for tag in tags:
tags_by_instance_id[tag.res_id][tag.name] = tag.value
for reservation in reservations: for reservation in reservations:
for instance in reservation.instances: for instance in reservation.instances:
instance.tags = tags_by_instance_id[instance.id]
self.add_instance(instance, region) self.add_instance(instance, region)
except boto.exception.BotoServerError as e: except boto.exception.BotoServerError as e: