[stable-9] Unit tests: make set_module_args() a context manager, and remove copies of it in some tests (#9840)

Unit tests: make set_module_args() a context manager, and remove copies of it in some tests (#9838)

Make set_module_args() a context manager, and remove copies of set_module_args().

Prepares for Data Tagging.

(cherry picked from commit a1781d09dd)
This commit is contained in:
Felix Fontein 2025-03-07 07:31:42 +01:00 committed by GitHub
parent 9a6bd80613
commit 013fb9c006
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
80 changed files with 3745 additions and 3977 deletions

View file

@ -48,10 +48,10 @@ class TestLvgRename(ModuleTestCase):
'vg': 'vg_missing',
'vg_new': 'vg_data_testhost2',
}
set_module_args(args=module_args)
with set_module_args(args=module_args):
with self.assertRaises(AnsibleFailJson) as result:
self.module.main()
with self.assertRaises(AnsibleFailJson) as result:
self.module.main()
self.assertEqual(len(self.mock_module_run_command.mock_calls), 1)
self.assertIs(result.exception.args[0]['failed'], failed)
@ -67,10 +67,10 @@ class TestLvgRename(ModuleTestCase):
'vg': 'Yfj4YG-c8nI-z7w5-B7Fw-i2eM-HqlF-ApFVp0',
'vg_new': 'vg_data_testhost2',
}
set_module_args(args=module_args)
with set_module_args(args=module_args):
with self.assertRaises(AnsibleFailJson) as result:
self.module.main()
with self.assertRaises(AnsibleFailJson) as result:
self.module.main()
self.assertEqual(len(self.mock_module_run_command.mock_calls), 1)
self.assertIs(result.exception.args[0]['failed'], failed)
@ -86,10 +86,10 @@ class TestLvgRename(ModuleTestCase):
'vg': 'vg_data_testhost1',
'vg_new': 'vg_sys_testhost2',
}
set_module_args(args=module_args)
with set_module_args(args=module_args):
with self.assertRaises(AnsibleFailJson) as result:
self.module.main()
with self.assertRaises(AnsibleFailJson) as result:
self.module.main()
self.assertEqual(len(self.mock_module_run_command.mock_calls), 1)
self.assertIs(result.exception.args[0]['failed'], failed)
@ -109,10 +109,10 @@ class TestLvgRename(ModuleTestCase):
'vg': '/dev/vg_data_testhost1',
'vg_new': 'vg_data_testhost2',
}
set_module_args(args=module_args)
with set_module_args(args=module_args):
with self.assertRaises(AnsibleExitJson) as result:
self.module.main()
with self.assertRaises(AnsibleExitJson) as result:
self.module.main()
self.assertEqual(len(self.mock_module_run_command.mock_calls), 2)
self.assertIs(result.exception.args[0]['changed'], changed)
@ -130,10 +130,10 @@ class TestLvgRename(ModuleTestCase):
'vg_new': 'vg_data_testhost2',
'_ansible_check_mode': True,
}
set_module_args(args=module_args)
with set_module_args(args=module_args):
with self.assertRaises(AnsibleExitJson) as result:
self.module.main()
with self.assertRaises(AnsibleExitJson) as result:
self.module.main()
self.assertEqual(len(self.mock_module_run_command.mock_calls), 1)
self.assertIs(result.exception.args[0]['changed'], changed)
@ -150,10 +150,10 @@ class TestLvgRename(ModuleTestCase):
'vg': 'vg_data_testhostX',
'vg_new': 'vg_data_testhost1',
}
set_module_args(args=module_args)
with set_module_args(args=module_args):
with self.assertRaises(AnsibleExitJson) as result:
self.module.main()
with self.assertRaises(AnsibleExitJson) as result:
self.module.main()
self.assertEqual(len(self.mock_module_run_command.mock_calls), 1)
self.assertIs(result.exception.args[0]['changed'], changed)